Jamie Heilman [2005-01-18 10:42 -0800]:
> > Changes: 
> >  sysfsutils (1.2.0-2) unstable; urgency=low
> >  .
> >    * sysfsutils.init: Use shell bash instead of sh. (closes: #291011)
> 
> Please do not use bash, just fix the real problem, I offered a patch
> in #291022 which does this (and more).

What is the _real_ problem? Using awk is a problem because it might
not be available at the time the init script runs (there is a reason
that init script can only use programs in /bin, not in /usr/bin).

> Additional bugs in the current script:
>   Your replacement of '.' to '/' isn't a good idea because there are
> paths in sysfs which can contain '.' -- my patch accounted for that as
> well.

Hmm, right. I think I should just drop support for separating the path
components with a dot (I wanted to make that similar to the procps
init script, but that does not have this problem).

>   You defined a configuration file variable, and then didn't use it,
> my patch took care of that too.

Sorry, will be fixed. 

Thanks!

Martin

-- 
Martin Pitt                       http://www.piware.de
Ubuntu Developer            http://www.ubuntulinux.org
Debian GNU/Linux Developer       http://www.debian.org

Attachment: signature.asc
Description: Digital signature

Reply via email to