Package: icon
Severity: important
Tags: patch

Automatic build of icon_9.4.2-2.1 on nighthawk by sbuild/hurd-i386 1.1.1.1
Build started at 20050130-1902
icon_9.4.2-2.1.dsc exists in cwd
** Using build dependencies supplied by package:
Build-Depends: xlibs-dev
Checking for already installed source dependencies...
xlibs-dev: missing
Checking for source dependency conflicts...
[...]
Checking correctness of source dependencies...
------------------------------------------------------------------------------
dpkg-source: extracting icon in icon-9.4.2
dpkg-buildpackage: source package is icon
dpkg-buildpackage: source version is 9.4.2-2.1
dpkg-buildpackage: host architecture is hurd-i386
[...]
gcc -Wall -g -O2   -c -o xwindow.o xwindow.c
gcc -Wall -g -O2   -c -o dlrgint.o dlrgint.c

And there it stops, and the machine reboots. Not really sure this is not
perhaps a machine-specific problem, but somebody else reported an
infinite loop with a subsequent reboot as well and the below patch made
the build go fine.

It appears the problem is in src/common/Makefile:

gpxmaybe:
                -if [ "x$(XL)" != "x" ]; then $(MAKE) $(GDIR); fi

while the test seems to be true on hurd-i386, $GDIR is not defined in
config/gnu/Makedef. The following patch fixes this by resyncing
config/gnu/Makedef with config/linux/Makedef. (-lpthread is needed on
GNU/Hurd as well)

As icon is in the Build-Depends for ifupdown (through nowebm) since
recently, and a new ifupdown as currently present on hurd-i386 is
mandated by netbase, the bootstrapping for hurd-i386 is broken currently
and this fix is urgently needed. Thus, I will NMU icon in the next days
if I don't hear back from you.


cheers,

Michael
diff -u icon-9.4.2/config/gnu/Makedefs icon-9.4.2/config/gnu/Makedefs
--- icon-9.4.2/config/gnu/Makedefs
+++ icon-9.4.2/config/gnu/Makedefs
@@ -1,17 +1,19 @@
-#  Makefile definitions from config/unix/gnu
-
 #  CC       C compiler
 #  CFLAGS   flags for building C files
 #  CFDYN    additional flags for dynamic functions
 #  RLINK    flags for linking run-time system
 #  RLIBS    libraries to link with run-time system
+#  TLIBS    libraries to link for POSIX threads
 #  XLIBS    libraries to link for graphics
 #  XPMDEFS  definitions for building XPM library
+#  GDIR     directory of graphics helper library
 
 CC = gcc
 CFLAGS = -O2
 CFDYN = -fPIC
 RLINK = -Wl,-E
 RLIBS = -lm -ldl
+TLIBS = -lpthread
 XLIBS = -L/usr/X11R6/lib -lX11
 XPMDEFS = -DZPIPE
+GDIR = xpm
diff -u icon-9.4.2/debian/changelog icon-9.4.2/debian/changelog
--- icon-9.4.2/debian/changelog
+++ icon-9.4.2/debian/changelog
@@ -1,3 +1,11 @@
+icon (9.4.2-2.2) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Update config/gnu/Makeconf according to config/linux/Makeconf to
+    prevent an infinite loop/system hang.
+
+ -- Michael Banck <[EMAIL PROTECTED]>  Sun, 30 Jan 2005 18:38:33 +0100
+
 icon (9.4.2-2.1) unstable; urgency=low
 
   * Non-maintainer upload during BSP

Reply via email to