On Tue, Mar 20, 2012 at 07:55:08PM +0100, Agustin Martin wrote:
> I have re-adapted patch enabling lua/tikz (#503269) to your just committed
> changes, please find it attached.

By the way, one more thing,

You may want to pass --as-needed to the linker to avoid linking against
unneeded libs, see attached patch for a proposal. This will be linker's
default at some time, but seems that not yet.

Also, just noticed that you may want to export LDFLAGS and CFLAGS after
changes for lua and --as-needed (I forgot to put it in my previous patch for
lua enabling -- not needed there since explicitly passed to configure -- and
not added here to keep patch atomic).

Regards,

-- 
Agustin
>From 5d84f1c7a0c252a06a269f0dbf48e4dd84af10a9 Mon Sep 17 00:00:00 2001
From: Agustin Martin Domingo <[email protected]>
Date: Tue, 20 Mar 2012 19:58:14 +0100
Subject: [PATCH] Pass --as-needed to linker. Avoids linking unneeded libs.

---
 debian/rules |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/debian/rules b/debian/rules
index 8d2910a..00726fa 100755
--- a/debian/rules
+++ b/debian/rules
@@ -9,6 +9,10 @@ export DEB_BUILD_GNU_TYPE ?= $(shell dpkg-architecture -qDEB_BUILD_GNU_TYPE)
 export CFLAGS := -Wall $(shell dpkg-buildflags --get CFLAGS)
 export LDFLAGS := $(shell dpkg-buildflags --get LDFLAGS)
 
+# Build structure may link against unneeded libs.
+# Make sure this does not happen.
+LDFLAGS            += -Wl,--as-needed
+
 # Tell compiler where should find lua headers
 CFLAGS += -I/usr/include/lua5.1
 
-- 
1.7.9.1

Reply via email to