Package: gnome-breakout Version: 0.5.3-3 Severity: important Tags: patch Dear Maintainer,
Please enable +format hardening.
The attached patch fixes the compile issues. It should be sent
upstream.
The following patch uses +all to also enable (possible) future
hardening flags.
diff -Nru gnome-breakout-0.5.3/debian/rules gnome-breakout-0.5.3/debian/rules
--- gnome-breakout-0.5.3/debian/rules 2011-12-04 10:21:06.000000000 +0100
+++ gnome-breakout-0.5.3/debian/rules 2012-03-22 18:51:09.000000000 +0100
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
-export DEB_BUILD_MAINT_OPTIONS := hardening=-format,+pie,+bindnow
+export DEB_BUILD_MAINT_OPTIONS := hardening=+all
%:
dh $@ --with autoreconf --with autotools-dev
Regards,
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
Description: Fix -Wformat-security errors. Author: Simon Ruderich <[email protected]> Last-Update: 2012-03-22 Index: gnome-breakout-0.5.3/src/gui.c =================================================================== --- gnome-breakout-0.5.3.orig/src/gui.c 2012-03-22 18:55:55.000000000 +0100 +++ gnome-breakout-0.5.3/src/gui.c 2012-03-22 18:55:55.000000000 +0100 @@ -362,7 +362,7 @@ GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_WARNING, GTK_BUTTONS_CLOSE, - buffer); + "%s", buffer); gtk_dialog_run(GTK_DIALOG(mbox)); gtk_widget_destroy(mbox); } else { @@ -386,7 +386,7 @@ GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_ERROR, GTK_BUTTONS_CLOSE, - buffer); + "%s", buffer); gtk_dialog_run(GTK_DIALOG(mbox)); gtk_widget_destroy(mbox); } else { Index: gnome-breakout-0.5.3/src/util.c =================================================================== --- gnome-breakout-0.5.3.orig/src/util.c 2004-05-11 00:35:32.000000000 +0200 +++ gnome-breakout-0.5.3/src/util.c 2012-03-22 18:58:40.889774594 +0100 @@ -41,6 +41,6 @@ message = g_strdup_vprintf(format, ap); va_end(ap); - g_warning(message); + g_warning("%s", message); g_free(message); }
signature.asc
Description: Digital signature
