Bug#330966: mozilla-firefox: Undefined value in patch "Ignore unused mouse buttons"

[Peter Colberg]

Package: mozilla-firefox
Version: 1.0.7-1
Severity: minor
Tags: patch

Back in April 2004 I submitted a patch to ignore mouse button events >= 8
in the button event handler routine (`nsWindow::OnButtonPressEvent'); the
relevant bug report is #244305.

After additionally filing an upstream bug report[1], it turned out that I
had carelessly left the value of variable `eventType' undefined in the
default case.

Could you please consider the following fix to add an early return in
the default case? The superfluous `break' statement was kept to conform
to the coding style (see function `nsWindow::OnButtonReleaseEvent').

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=250143


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (700, 'unstable')
Architecture: amd64 (x86_64)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.13.2-maia
Locale: LANG=C, [EMAIL PROTECTED] (charmap=ISO-8859-15)

diff -u mozilla-firefox-1.0.7/widget/src/gtk2/nsWindow.cpp 
mozilla-firefox-1.0.7/widget/src/gtk2/nsWindow.cpp
--- mozilla-firefox-1.0.7/widget/src/gtk2/nsWindow.cpp
+++ mozilla-firefox-1.0.7/widget/src/gtk2/nsWindow.cpp
@@ -1406,6 +1406,7 @@
         eventType = NS_MOUSE_RIGHT_BUTTON_DOWN;
         break;
     default:
+        return;
         break;
     }