Hi,

adrian15 wrote (06 Apr 2012 18:39:46 GMT) :
>>> I've even improved the part about checking that the iso was mounted
>>> that intrigeri pointed out at:
>>> http://lists.debian.org/debian-live/2011/09/msg00067.html
>>
>> So you have replaced
>>
>>    grep -q /live/findiso /proc/mounts&&  umount /root/live/findiso
>>
>> with
>>
>>    [ ! -z ${mountpoint} ]&&  umount /root/live/findiso
>>
>> It seems more fragile to me than what the original patch did (although
>> it did in a way I did not like); but maybe you can explain us why this
>> new check is sufficient and/or better suited than the old one?

> Well, actually, I wanted to ask you what did you mean when you said
> that exactly but I didn't think of sending you an email.

I suggested using the mountpoint *command* instead of the ugly
grep hack.

> I can re-submit the patch without this change or try to implement
> whatever you meant if you explain it.

Please do.

Cheers,
-- 
  intrigeri
  | GnuPG key @ https://gaffer.ptitcanardnoir.org/intrigeri/intrigeri.asc
  | OTR fingerprint @ https://gaffer.ptitcanardnoir.org/intrigeri/otr.asc



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to