reassign 668825 subcommander
tags 668825 patch
thanks

[Robert Luberda]
> I guess subcommander uses some libsvn symbols that it shouldn't use,
> however I have no idea how to find which ones. That's why I'm
> reporting this bug against libsvn-dev.

Good guess, but ... oooh.  Interesting - I haven't seen this failure
mode before.  subcommander links to lots of Subversion libraries,
including several it does not need (whole libraries are more or less
'private use').  Some of those, in turn, use some of these private
symbols.

At some point I stopped shipping .la files and .so symlinks for these
private libraries, intending to not let you link to them at all, but I
do still ship .a files for them, because if you need .a files at all,
you need all of them.  Thus it happened that subcommander ended up
statically linking to the private libraries, and dynamically linking to
everything else.

I'm attaching a patch to subcommander 'configure.ac'.  It builds.
I haven't tested to see if subcommander runs properly, as I don't
use it.

Thanks!
Peter
--- a/configure.ac
+++ b/configure.ac
@@ -373,23 +373,11 @@ fi
 if test $SVN_MAJOR -ge 1; then
 
   SVN_LIBS_ALL="$SVN_LIBS -lsvn_client-1 -lsvn_wc-1 -lsvn_repos-1"
-  SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_ra-1 -lsvn_ra_svn-1 -lsvn_ra_local-1"
-  SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_fs-1 -lsvn_fs_fs-1"
+  SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_ra-1"
+  SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_fs-1"
   SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_delta-1 -lsvn_diff-1"
   SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_subr-1"
 
-  if test $SVN_MINOR -eq 4; then
-    SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_ra_dav-1"
-  elif test $SVN_MINOR -ge 5; then
-    if test x$found_neon = xyes; then
-      SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_ra_neon-1"
-    fi
-    if test x$found_serf = xyes; then
-      SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_ra_serf-1"
-    fi
-    SVN_LIBS_ALL="$SVN_LIBS_ALL -lsvn_fs_util-1"
-  fi
-
 fi
 
 if test x$goodsvn == xok; then

Reply via email to