Package: multistrap
Version: 2.1.17
Severity: normal
Tags: patch
The new feature 'ignorenativearch' doesn't appear to affect anything.
If I set "ignorenativearch=true" in the general section of my config,
the $ignorenative variable is incremented (to 1), but $foreign remains
unset. Later calls to the native() function check if $foreign is
defined.
It seems like the issue here is some incorrect logic for setting
$native. Specifically, it should be 1 if $host!=$arch *or* if
$ignorenative is set; after all, we're setting ignorenativearch
because $host may equal $arch, but we want $foreign set anyways.
Also, $ignorenative is listed twice in the global variable section; I'm
assuming that's an oversight.
This patch fixes up both things.
--- a/multistrap 2012-04-18 01:01:23.000000000 -0700
+++ b/multistrap 2012-04-18 01:01:05.000000000 -0700
@@ -36,7 +36,7 @@
$explicit_suite $allow_recommends %omitdebsrc @dsclist @sectoutput
%flatfile %important $addimportant @debconf $hookdir %hooks
$warn_count $use_shortcut @foreignarches $olddpkg $ignorenative
- %foreignpkgs $ignorenative /;
+ %foreignpkgs /;
setlocale(LC_MESSAGES, "");
textdomain("multistrap");
@@ -146,7 +146,7 @@
} else {
printf (_g("Using foreign architecture: %s\n"), $arch);
}
-$foreign++ if (($host ne $arch) and (not defined $ignorenative));
+$foreign++ if (($host ne $arch) or (defined $ignorenative));
unless (keys %sources) {
my $msg = sprintf(_g("No sources defined for a foreign multistrap.
Using your existing apt sources. To use different sources,
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
