Package: mediainfo Version: 0.7.56-1 Severity: important Tags: patch Dear Maintainer,
The LDFLAGS hardening flags are missing because they are
overwritten in debian/rules.
DEB_*_MAINT_APPEND is the preferred way to set additional flags
(see man dpkg-buildflags for more information). For more
hardening information please have a look at [1], [2] and [3].
The following patch fixes the issue.
diff -Nru mediainfo-0.7.56/debian/rules mediainfo-0.7.56/debian/rules
--- mediainfo-0.7.56/debian/rules 2012-04-22 15:38:24.000000000 +0200
+++ mediainfo-0.7.56/debian/rules 2012-04-28 20:46:59.000000000 +0200
@@ -1,6 +1,6 @@
#!/usr/bin/make -f
-export LDFLAGS = -Wl,-z,defs -Wl,--as-needed
+export DEB_LDFLAGS_MAINT_APPEND = -Wl,-z,defs -Wl,--as-needed
auto_build_cmd = \
cat debian/autoreconf | while read path; do \
To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (for example with blhc [4]) (hardening-check
doesn't catch everything):
$ hardening-check /usr/bin/mediainfo /usr/bin/mediainfo-gui
/usr/bin/mediainfo:
Position Independent Executable: no, normal executable!
Stack protected: yes
Fortify Source functions: no, only unprotected functions found!
Read-only relocations: yes
Immediate binding: no not found!
/usr/bin/mediainfo-gui:
Position Independent Executable: no, normal executable!
Stack protected: yes
Fortify Source functions: no, only unprotected functions found!
Read-only relocations: yes
Immediate binding: no not found!
(Position Independent Executable and Immediate binding is not
enabled by default.)
Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.
Regards,
Simon
[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
[4]: http://ruderich.org/simon/blhc/
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: Digital signature
