On 12.05.2012 12:57, Giuseppe Iuculano wrote:
> You can check the diff of the fix at:
> 
>     
> http://git.debian.org/?p=collab-maint/smartmontools.git;a=commitdiff;h=9a19418

The fix is incorrect for two reasons.

bash requires the space after the opening curly brace, otherwise it will
consider it a word for brace expansion instead of the beginning of a
command list. This isn't perfectly clear from the bash docs, but a
simple example on the command line will clearly exhibit that problem.

bash also requires a final semicolon to end the list of commands. That
fact has been explicitely stated in bash docs. A space after that
appears to be optional, but for reasons of symmetry I'd add one as well.

I suggest you improve the fix accordingly.



-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to