On Sun, May 13, 2012 at 07:20:29PM +0200, Daniel Dehennin wrote: > Guido Günther <[email protected]> writes: > > > [...] > > > Looks great! Can you document commit1 and commit2 via epydoc too and add > > a testcase to tests/test_GitRepository.py that tests the success as well > > as the failure case? > > Ok, I'll do that. > > > As a bonus construct the args argument via args = GitArgs(commit1, > > commit2) > > > > for consistency with other recent code. I'd be happy to apply it then. > > I did it in my first implementation, but Repository._git_inout() does > not like it :-/
You can use args.args to convert it back to a list. Cheers, -- Guido > > Regards. > > -- > Daniel Dehennin > Récupérer ma clef GPG: > gpg --keyserver pgp.mit.edu --recv-keys 0x7A6FE2DF -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
