Source: eina
Version: 1.2.0
Severity: serious
Tags: upstream patch
Justification: fails to build from source (but built successfully in the past)

This package makes a few assumptions which prevent it from being built on 
architectures
which have an unsigned char.

I am attaching a patch to fix one of these, but this second one, I am not 
positive what
is being attempted. This test is failing on the cast from a 
EINA_VALUE_TYPE_TIMEVAL
to EINA_VALUE_TYPE_CHAR:

START_TEST(eina_value_test_timeval)
{
   Eina_Value *value, other;
   struct timeval itv, otv;
   char c;
   char *str;

   eina_init();

   value = eina_value_new(EINA_VALUE_TYPE_TIMEVAL);
   fail_unless(value != NULL);

....

   fail_unless(eina_value_setup(&other, EINA_VALUE_TYPE_CHAR));
   fail_unless(eina_value_convert(value, &other));
   fail_unless(eina_value_get(&other, &c));
   fail_unless(c == 2);
   eina_value_flush(&other);


-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable-grip
  APT policy: (200, 'unstable-grip'), (101, 'unstable'), (100, 'experimental')
Architecture: armel (armv5tel)

Kernel: Linux 3.4.0-rc4-tomoyo-00002-gf203d42 (PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
>From 63d5cd4b044b834f0e01cc4224a54655629c8555 Mon Sep 17 00:00:00 2001
From: Shawn Landen <shawnland...@gmail.com>
Date: Tue, 15 May 2012 01:35:30 -0700
Subject: [PATCH] fix signed char assumption in test suite

---
 src/tests/eina_test_value.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/tests/eina_test_value.c b/src/tests/eina_test_value.c
index d369208..4b6aef0 100644
--- a/src/tests/eina_test_value.c
+++ b/src/tests/eina_test_value.c
@@ -142,7 +142,7 @@ START_TEST(eina_value_test_compare)
    fail_unless(eina_value_set(a, 123));
    fail_unless(eina_value_set(b, 123));
    fail_unless(eina_value_compare(a, b) == 0);
-   fail_unless(eina_value_set(a, -10));
+   fail_unless(eina_value_set(a, 10));
    fail_unless(eina_value_set(b, 123));
    fail_unless(eina_value_compare(a, b) < 0);
    fail_unless(eina_value_set(a, 123));
-- 
1.7.10

Reply via email to