On Tue, Apr 13, 2010 at 04:34:22PM +0200, Fabian Greffrath wrote: > unarchive 388250 > reopen 388250 > found 388250 0.63.1 > tags 388250 + patch > thanks
Thanks for your bugreport and your patch and sorry for my (super) slow reply. [..] > >(1) In the main menu there is an entry called "Package / Download > >Changelog". It would be nice to also have another entry called "Download > >Copyright", which will show the copyright file. > > > >This is extremely interesting for new packages in non-free/contrib and > >in all cases when you want to know what the heck you are downloading at > >all. ;) > > This is covered by download-copyright-file.patch. I have introduced > another menu entry "Download Copyright File" next to "Download > Changelog" and reuse most of the code that is currently used to > retrieve the changelog file. This even becomes visible in the actual > text view window itself, when the following text is still introduced > as the most current changelog, although the copyright file is shown. > > But, hey, at least it's a starting point. ;) > > While we are at it, I introduced "Y" as an accelerator key for this > menu entry. I merged this (and updated it for gtkbuilder instead of glade) into "bzr branch lp:~mvo/synaptic/debian-bug388250" Before mering to trunk I think the code needs to be refactored a bit to get rid of the duplications with the changelog view code, that is hopefully easy. Are you (still) interessted in working on this? > >(2) Could you please introduce a keyboard shortcut for the "Show > >Changelog" function? A suggestion would be "F5" or similar. If you > >decide to add the "Show Copyright" function, a keyboard shortcut for > >this (maybe "F6") would be nice, too. > > This issue is covered by changelog-accelerator.patch. It introduces > "L" as an accelerator key for the "Download Changelog" function (I > have checked that it was not assigned so far). That's all. This is uncontroversial. I updated it for gtkbuilder and its in the same branch. Thanks, Michael -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
