Source: openfetion
Version: 2.2.1-3
Severity: important
Tags: patch

Hi,

with the recent upload of libindicate to unstable [1], your package will
 build without indicator support
due to the bumped libindicate API (reflected in the pkg-config name).

I am sorry to give such short/late notice, but the release team catched
me pretty unprepared with their "trnaisiton NOW or after wheezy" mail.
(So blame me and give the nice RT guys some beer/coffee ;-))

As your package already has a patch for the last API bump, I just attach
a slightly modified version of it that will work with indicate-0.7. It
should be properly renamed etc :)

As the new library is binary compatible with the old one, your package
does not need a rebuild and should still work and thus does not hold
back the transition. I still would love to see the patch in unstable
soon. For that I plan to prepare a NMU and upload it to DELAYED/5 either
tomorrow or the day after, if there are no objections from your side.

Regards
Evgeni Golov

PS: again, sorry for the short timeframe

[1] http://packages.qa.debian.org/libi/libindicate/news/20120521T094831Z.html

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.2.0-2-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
From: Evgeni Golov <[email protected]>
Debian-Bug: http://bugs.debian.org/660773
Last-Update: 2012-02-26
Subject: port openfetion to new libindicate-gtk 0.7
 * change the module to check via pkg-config to libinficate-gtk-0.7
 * use indicate_gtk_indicator_set_property_icon instead of
   indicate_indicator_set_property_icon

Index: openfetion-2.2.1/CMakeLists.txt
===================================================================
--- openfetion-2.2.1.orig/CMakeLists.txt	2011-05-09 10:14:28.000000000 +0200
+++ openfetion-2.2.1/CMakeLists.txt	2012-05-15 17:59:09.000000000 +0200
@@ -82,7 +82,7 @@
 if(WITH_INDICATE)
 	pkg_check_modules(INDICATE indicate)
 	pkg_check_modules(INDICATE_GTK indicate-gtk)
-	pkg_check_modules(INDICATE_GTK_NEW indicate-gtk-0.5)
+	pkg_check_modules(INDICATE_GTK_NEW indicate-gtk-0.7)
 endif(WITH_INDICATE)
 
 ##########################################################################
Index: openfetion-2.2.1/src/fx_main.c
===================================================================
--- openfetion-2.2.1.orig/src/fx_main.c	2011-05-09 10:14:28.000000000 +0200
+++ openfetion-2.2.1/src/fx_main.c	2012-05-15 17:59:09.000000000 +0200
@@ -692,7 +692,7 @@
 	/* set icon */
 	snprintf(portrait, sizeof(portrait) - 1, "%s/%s.jpg", fxmain->user->config->iconPath, sid);
 	pixbuf = gdk_pixbuf_new_from_file(portrait, NULL);
-	indicate_indicator_set_property_icon(indicator, INDICATE_INDICATOR_MESSAGES_PROP_ICON, pixbuf);
+	indicate_gtk_indicator_set_property_icon(indicator, INDICATE_INDICATOR_MESSAGES_PROP_ICON, pixbuf);
 	g_object_unref(pixbuf);
 
 	g_signal_connect(G_OBJECT(indicator), INDICATE_INDICATOR_SIGNAL_DISPLAY,

Reply via email to