Package: libedit Version: 2.11-20080614-4 Severity: normal Tags: patch Dear Maintainer,
The LDFLAGS hardening flags are missing for libedit.so.2.11
because the build system ignores them. For more hardening
information please have a look at [1], [2] and [3].
The following patch fixes the issue.
diff -Nru libedit-2.11-20080614/debian/rules libedit-2.11-20080614/debian/rules
--- libedit-2.11-20080614/debian/rules 2012-05-31 09:00:47.000000000 +0200
+++ libedit-2.11-20080614/debian/rules 2012-05-31 23:25:06.000000000 +0200
@@ -9,7 +9,7 @@
PKGDIR = ${CURDIR}/debian/tmp
PMAKE_ARGS = MKPROFILE=no MKCATPAGES=no MLINKS= MANPAGES= \
SHLIB_SHFLAGS="-Wl,-soname,libedit.so.${major}" \
- LDADD="-lbsd -ltinfo"
+ LDADD="$(LDFLAGS) -lbsd -ltinfo"
EDITLINE_3_LINKS = el_init el_end el_reset el_gets el_getc el_push \
el_parse el_set el_get el_source el_resize el_line \
el_insertstr el_deletestr history_init history_end history
To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log (for example with blhc [4]) (hardening-check
doesn't catch everything):
$ hardening-check /usr/lib/x86_64-linux-gnu/libedit.so.2.11
/usr/lib/x86_64-linux-gnu/libedit.so.2.11:
Position Independent Executable: no, regular shared library (ignored)
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
Read-only relocations: yes
Immediate binding: no not found!
(Position Independent Executable and Immediate binding is not
enabled by default.)
Use find -type f \( -executable -o -name \*.so\* \) -exec
hardening-check {} + on the build result to check all files.
Regards,
Simon
[1]: https://wiki.debian.org/ReleaseGoals/SecurityHardeningBuildFlags
[2]: https://wiki.debian.org/HardeningWalkthrough
[3]: https://wiki.debian.org/Hardening
[4]: http://ruderich.org/simon/blhc/
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
signature.asc
Description: Digital signature
