Le 07/06/2012 15:00, Romain Bignon a écrit :
> Hi,
>
> Sorry I did not have time to answer to your mail.
>
> On 23/May - 12:55, Vincent Danjean wrote:
>> I tried to improve it a little. You can find the result here:
>> git://git.ligforge.imag.fr/git/users/vdanjean/debian/weboob.git
>> I would be very pleased if you are interested my my suggestions.
>> Note that debian patches whose name begin by for-upstream should
>> probably be pushed upstream instead of beeing kept as debian patches.
>
> Nice changes! But I have some questions:
>
> - Why have you changed the tarball?
The tarball is the one found on the upstream website (weboob-0.c.tar.gz).
I think you made a mistake or the tarball changed on the website without
changing the version number
> - Why do you install modules locally? The goal of the repository system is to
> publish fixes of modules (for example when a module is broken because of a
> change on the associated website) without releasing a new version of Weboob.
> If you force Debian users to use local modules, half of the modules will be
> unusable in six months.
The idea is to allow a local admin-managed repository. As plugins
for iceweal can be installed by the user (he is then responsible for
update) or by the admin (and update and security can be handled by
the usual tools such as apt-get...)
With my solution, a user can install his modules with the Debian
package (or with other local Debian packages...) or he can download
them manually. Debian package for stable can be updated through
backport.
But perhaps the order of upstream repo and Debian one should be
changed. There is no version number for modules ? Else, weboob can
load the one with the highest version number when a module exists
in several repo.
> - Scripts in contrib/ are not examples, they can be used as is.
They were not packaged. I prefer to find them in example than having
to download the sources and find them in it. Of course, the best
solution would be to install them into the path, but then a manpage
is required...
Regards,
Vincent
> Thanks for your work.
>
> Romain
>
--
Vincent Danjean Adresse: Laboratoire d'Informatique de Grenoble
Téléphone: +33 4 76 61 20 11 ENSIMAG - antenne de Montbonnot
Fax: +33 4 76 61 20 99 ZIRST 51, avenue Jean Kuntzmann
Email: [email protected] 38330 Montbonnot Saint Martin
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
