On 2012-06-20 23:12:59 -0500, Peter Samuelson wrote:
> retitle 678346 subversion: 'svn log' output tricked by symlinks in some cases

AFAIK, not just "log" is affected.

> tl;dr  I'm closing this because I believe it is a bugfix, not a bug.

Well, I disagree. The old behavior was a very practical feature.
And that's the goal of the symlinks: to be able to access objects
through them.

> I'm marking it found in 1.1.0, not because I've tested it, but because
> that is when symlink support was added to svn.

Actually this is not related to symlink support by svn. There is the
same difference with an unversioned symlink inside a working copy.
However with a symlink outside a working copy to the root of the WC,
this still works.

> [Vincent Lefevre]
> > svnadmin create svn
> > svn co file://`pwd`/svn wc
> > cd wc
> > svn mkdir foo
> > ln -s foo bar
> > svn add bar
> > touch foo/file
> > svn add foo/file
> ...
> > svn log bar/file
> > svn: E155010: The node '/tmp/my-test-svn/wc/bar/file' was not found.
> 
> In other words, 'svn log' is now more consistent between a working copy
> and a repository.  Compare:
> 
>     svn log bar/file
>     svn log file://`pwd`/svn/bar/file

Well, a path and a URL are different things. Do not expect them to
behave in the same way. On the other hand, a new inconsistency has
been introduced on paths (see above).

> In 1.7, they both fail.  In 1.6, one succeeds and one fails.

I don't see this as a problem: paths were more powerful, that's all.

>  I think the 1.7 behavior is clearer. There is no object in the
> repository named 'bar/file', and svn log no longer is fooled into
> reporting one.
> 
> Also, links are not resolved at the end of the path.  Compare 'svn log
> foo' with 'svn log bar'.  In both 1.6 and 1.7, 'bar' is its own object
> with its own log, independent of what it points to.

Again, I don't see this as a problem. With 1.6, the behavior is
similar to the "ls" command.

If the change is really intended, perhaps this should be controlled
by an option, with the 3 possible behaviors (1: never resolve symlinks;
2: resolve internal symlinks, like 1.6 and ls; 3: resolve symlinks
completely).

-- 
Vincent Lefèvre <[email protected]> - Web: <http://www.vinc17.net/>
100% accessible validated (X)HTML - Blog: <http://www.vinc17.net/blog/>
Work: CR INRIA - computer arithmetic / AriC project (LIP, ENS-Lyon)



--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to