Hello Johann, On Fri, Jun 22, 2012 at 10:20:34AM +0200, Jeroen Schot wrote: > On Fri, Jun 22, 2012 at 02:17:02AM +0200, Johann Felix Soden wrote: > > thanks for adopting wmctrl! I would sponsor your package, but please > > fix the following small issues first: > > > > - use the current homepage in debian/watch > > Yes, forgot that uscan could also work that way. > > > - remove 03_makefile_prelibs.patch (it is not in debian/patches/series > > and does not work because either Makefile.in need to be patched > > or you need to call automake, e.g. by using dh_autoreconf). > > Sorry, this file should not have been there. Indeed I tested this in > combination with dh_autoreconf, but decided to revert it. > > > To get the intended feature, simply add to debian/rules: > > > > override_dh_auto_build: > > dh_auto_build -- LDFLAGS+=-Wl,--as-needed > > Thanks, will try that. I did not find this while searching for the > linking warning. > > > - not yet needed, but would be nice: copyright-format-1.0
I think I addressed all the issues you mentioned, including the copyright-format-1.0. I fixed the linking issue by adding this to debian/rules: export DEB_LDFLAGS_MAINT_APPEND = -Wl,--as-needed Additions to the changelog: [...] * Link with --as-needed to avoid useless dependencies. * Update debian/watch file. * Convert debian/copyright to copyright-format 1.0. Thanks for taking the time for your review! The updated package is available from the same location as before. Kind regards, Jeroen Schot -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org