-------- Original Message --------
Subject: Re: [goswin-...@web.de: Bug#676645: Buffer overflow in
find_disk_space() causing stack corruption]
Date: Sat, 23 Jun 2012 13:42:28 +0000
From: Daniel Pocock <dan...@pocock.com.au>
To: Goswin von Brederlow <goswin-...@web.de>
CC: Stu Teasdale <s...@drogna.org.uk>
On 14/06/12 09:09, Goswin von Brederlow wrote:
> Daniel Pocock <dan...@pocock.com.au> writes:
>
>> On 12/06/12 08:40, Goswin von Brederlow wrote:
>>> Daniel Pocock <dan...@pocock.com.au> writes:
>>>
>>>> On 08/06/12 14:18, Stu Teasdale wrote:
>>>>> FYI
>>>>
>>>> Not sure why I didn't receive this bug report directly...
>>>>
>>>> Goswin, thanks for the patch - are you a committer on the main Ganglia
>>>> github project, or do you have a github ID? Can I give you access to
>>>> commit the patch directly?
>>>>
>>>> Regards,
>>>>
>>>> Daniel
>>>
>>> Neigther. But with git you can commit the patch with
>>>
>>> git commit --author="Goswin von Brederlow <goswin-...@web.de>"
>>>
>>
>> I'm quite happy to do that, but it would be good to have some more
>> contributors on the ganglia-modules-linux code base too - would you be
>> interested?
>
> I'm afraid not. Ganglia is just one of many packages we use at work and
> the only reason I looked at it was that it failed. If it breaks then its
> part of my work to fix it. But I'm not interested enough in ganglia to
> get really involved.
>
Hi Goswin,
The most essential part of the patch, buffer size, was already increased
in some version after 3.1.7 and it is good in 3.4.0
The other part of your patch (using index() for performance) has been
committed to trunk, it is also cherry-picked onto the 3.4 branch for the
next 3.4 series release.
Given that wheezy is about to freeze and will probably have 3.3.x or
3.4.x, is there an urgent need for a backport of this fix in squeeze
(e.g a 3.1.8 release)?
If not, can you please close the bug?
Regards,
Daniel
commit d786ec17d5a31819a1f7109a3a00cd09539750d7
Author: Goswin von Brederlow <goswin-...@web.de>
Date: Sat Jun 23 15:36:05 2012 +0200
With NFS mounts the entry in /proc/mounts and /etc/mtab can be long.
This patch splits the entry into its components in place using index()
instead of copying the strings into fixed sized arrays.
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
