Source: snappy-player
Version: 0.2-1
Severity: normal
Tags: upstream patch
Dear Maintainer,
$ cat ~/.config/snappy/history
$
$ snappy -r
These are the recently viewed URIs:
Segmentation fault
$ rm -rf .config/snappy/
george@sid:~$ snappy -r
These are the recently viewed URIs:
Segmentation fault
george@sid:/tmp/snappy-player-0.2/src$ gdb ./snappy
GNU gdb (GDB) 7.4.1-debian
Copyright (C) 2012 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law. Type "show
copying"
and "show warranty" for details.
This GDB was configured as "x86_64-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /tmp/snappy-player-0.2/src/snappy...done.
(gdb) run -r
Starting program: /tmp/snappy-player-0.2/src/snappy -r
[Thread debugging using libthread_db enabled]
Using host libthread_db library
"/lib/x86_64-linux-gnu/libthread_db.so.1".
These are the recently viewed URIs:
Program received signal SIGSEGV, Segmentation fault.
process_args (argc=1, argv=0x7fffffffe3f8,
file_list=file_list@entry=0x7fffffffe2a0,
fullscreen=fullscreen@entry=0x7fffffffe2d8,
secret=secret@entry=0x7fffffffe2dc, context=context@entry=0x6108b0)
at snappy.c:96
96 for (c = 0; recent[c] != NULL; c++) {
(gdb) list
91
92 g_print ("These are the recently viewed URIs: \n\n");
93
94 recent = get_recently_viewed ();
95
96 for (c = 0; recent[c] != NULL; c++) {
97 if (c < 9)
98 g_print ("0%d: %s \n", c + 1, recent[c]);
99 else
100 g_print ("%d: %s \n", c + 1, recent[c]);
(gdb) p recent
$1 = (gchar **) 0x0
(gdb)
The attached patch fixes this for me. Please fix the diff headers
when BTS bug number entry is returned (add to series as well).
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 3.2.0-3-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
Description: <short summary of the patch>
TODO: Put a short summary on the line above and replace this paragraph
with a longer explanation of this change. Complete the meta-information
with other relevant fields (see below for details). To make it easier, the
information below has been extracted from the changelog. Adjust it or drop
it.
.
snappy-player (0.2-1) unstable; urgency=low
.
* New upstream release, "Mrs. Robinson, you're trying to seduce me.":
+ debian/control:
- Build-depend on GLib >= 2.26 for GDBus, libxtst and
gst-plugins-base >= 0.10.30.
Author: Sebastian Dröge <sl...@debian.org>
---
The information above should follow the Patch Tagging Guidelines, please
checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
are templates for supplementary fields that you might want to add:
Origin: <vendor|upstream|other>, <url of original patch>
Bug: <url in upstream bugtracker>
Bug-Debian: http://bugs.debian.org/<bugnumber>
Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
Forwarded: <no|not-needed|url proving that it has been forwarded>
Reviewed-By: <name and email of someone who approved the patch>
Last-Update: <YYYY-MM-DD>
--- snappy-player-0.2.orig/src/snappy.c
+++ snappy-player-0.2/src/snappy.c
@@ -89,9 +89,13 @@ process_args (int argc, char *argv[],
if (recent) {
gchar **recent = NULL;
- g_print ("These are the recently viewed URIs: \n\n");
-
recent = get_recently_viewed ();
+ if(!recent) {
+ g_print ("There are no recently viewed URIs.\n\n");
+ goto quit;
+ }
+
+ g_print ("These are the recently viewed URIs: \n\n");
for (c = 0; recent[c] != NULL; c++) {
if (c < 9)
