On Sun, 2005-09-25 at 00:21 +0200, Marco d'Itri wrote:
> What do you think about this proposed change?

> > Hello,
> > 
> > while rewritting the init script of sl-modem-daemon I noticed that
> > modprobe -r does not have reliable && consistant && useful error codes.
> > That means, it differs from rmmod and does the following:
> > 
> >  - if a module is not loaded, it returns 0
> >  
> >  - if the module is not loaded and is also not available, it returns 1
> >  
> >  - if the module was in use, it also returns 1. It would be nice to see
> >    the reason for the failure encoded in the return code
> > 
> > The first two should be consistent, I prefer having both return a false
> > value, 1.

Hmm, modprobe was changed to be idempotent on insert, and that was
mirrored in -r.  You want --first-time to make not loaded fail.

Agreed about return values, though.  Patch welcome.

Rusty.
-- 
A bad analogy is like a leaky screwdriver -- Richard Braakman


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to