On Wed, August 8, 2012 01:15, Cyril Brulebois wrote: > Thijs Kinkhorst <[email protected]> (07/08/2012): >> On Tue, August 7, 2012 01:44, Cyril Brulebois wrote: >> > while I have only glanced at it, that doesn't look bad at all, >> > please go ahead and ping us once it's accepted. >> >> It has now been accepted. > > Thanks. Now that I have a little more time, finally looking at it for > real. > > OK for doc changes, and $Id$ noise (â¦). > > I think I can see what the key dance part of the patch does, too. > > That is totally obscure to me though: > - if (!$newDoc->loadXML($xml)) { > + if (!@$newDoc->loadXML($xml)) { > > What does that do? Fix a bug, silence a language warning, or anything > else?
It silences a language warning: if the loadXML call fails the interpreter would output a warning, but this is handled more gracefully already by throwing an exception straight below it. Cheers, Thijs -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
