Package: python-aptdaemon
Version: 0.45-1
Tags: patch

A (potential) error in worker.py(_mark_packages_for_upgrade),
introduced in revision 336[1]:

-            auto = not self._cache._depcache.IsAutoInstalled(pkg._pkg)
-            pkg.markInstall(False, True, auto)
+            pkg.mark_install(False, True, pkg.is_auto_installed)

causes previously auto-installed packages to be marked manually
installed when upgraded with upgrade_packages or commit_packages.

The error is then propagated to _mark_packages_for_downgrade,
introduced in revision 449.1.3[2].

Python-apt has package.py(mark_upgrade) which uses “not
pkg.is_auto_installed” as from_user, the final argument to
mark_install.  This suggests the original code is intended.

Attached fix and test case.  Please disregard if the change in
behaviour was intentional.

[1] 
http://bazaar.launchpad.net/~aptdaemon-developers/aptdaemon/main/revision/336
[2] 
http://bazaar.launchpad.net/~aptdaemon-developers/aptdaemon/main/revision/449.1.3

Attachment: upgrade-auto.patch
Description: Binary data

Reply via email to