reopen 685670 thanks Hello,
The attached patch adds the missing CPPFLAGS/LDFLAGS. Not sure if
that's possible for Wheezy, if not it should be fixed in sid.
To check if all flags were correctly enabled you can use
`hardening-check` from the hardening-includes package and check
the build log with `blhc` (hardening-check doesn't catch
everything):
$ hardening-check /usr/bin/htop
/usr/bin/htop:
Position Independent Executable: no, normal executable!
Stack protected: yes
Fortify Source functions: yes (some protected functions found)
Read-only relocations: yes
Immediate binding: no not found!
(Position Independent Executable and Immediate binding is not
enabled by default.)
Regards,
Simon
--
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
diff -u htop-1.0.1/debian/rules htop-1.0.1/debian/rules
--- htop-1.0.1/debian/rules
+++ htop-1.0.1/debian/rules
@@ -17,6 +17,8 @@
endif
CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
+CPPFLAGS = $(shell dpkg-buildflags --get CPPFLAGS)
+LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
config.status: configure $(QUILT_STAMPFN)
dh_testdir
@@ -31,7 +33,7 @@
[ ! -r /usr/share/misc/config.guess ] || \
cp -f /usr/share/misc/config.guess config.guess
- CFLAGS="$(CFLAGS)" LDFLAGS="$(INSTALL_PROGRAM)" ./configure \
+ CFLAGS="$(CFLAGS)" CPPFLAGS="$(CPPFLAGS)" LDFLAGS="$(LDFLAGS) $(INSTALL_PROGRAM)" ./configure \
--host=$(DEB_HOST_GNU_TYPE) --build=$(DEB_BUILD_GNU_TYPE) \
--prefix=/usr --mandir=\$${prefix}/share/man \
--infodir=\$${prefix}/share/info \
signature.asc
Description: Digital signature
