On Sat, Sep 15, 2012 at 04:32:35PM +0200, Andreas Metzler wrote: > Hello,
Hello Andreas, > I have just taken a look at the patches: > * exim_debian_rules.patch looks fine. > * fix-missing-ldflags.patch does not really fit. Exim uses LFLAGS > where GNU buildsystem uses LDFLAGS. However src/EDITME (mis)uses > LDFLAGS to pass on special libraries (SRS, SPF) when linking the > main daemon binary. Therefore I think > export LFLAGS += $(LDFLAGS) > in debian/rules is the better fix. Ah, even better. I was just confused because I found LFLAGS and LDFLAGS so I wasn't sure which flags are used for what. > The change to OS/Makefile-Base (adding LFLAGS when linking a helper > binary, only used when preparing the build infrastructure) looks > fine. I will forward it. > * fix-too-verbose.patch: Does not work for upstream as building > without FULLECHO='' would echo nothing at all. Yeah, it was just a quick fix to run the build log through blhc. I don't know how to disable a line completely when a flag is set. If you know a way to do that - and think upstream would accept such a patch, please tell me and I'll write one for all Makefiles. > * makefile-missing-fullecho.patch Nice catch, will forward upstream. Regards, Simon -- + privacy is necessary + using gnupg http://gnupg.org + public key id: 0x92FEFDB7E44C32F9
pgpfDa7TFG7SQ.pgp
Description: PGP signature
