Package: gforth
Version: 0.7.0+ds1-7
Severity: wishlist
Tags: upstream patch
When having emacs-snapshot installed, the gforth package fails to
configure, due to an elisp compilation error:
,----
| Install gforth for emacs-snapshot
| install/gforth: Byte-compiling for emacsen flavour emacs-snapshot
|
| In toplevel form:
| gforth.el:742:18:Error: Don't know how to compile nil
| gforth.el:742:18:Error: Don't know how to compile nil
| gforth.el:742:18:Error: Don't know how to compile nil
| gforth.el:742:18:Error: Don't know how to compile nil
| gforth.el:742:18:Error: Don't know how to compile nil
| ERROR: install script from gforth package failed
`----
The attached patch removes invocations of `byte-compile' from
gforth.el, which rectifies this issue. I'm not sure whether it might
have any negative (perfomance, perhaps?) impact. Also noteworthy in
this context is the following German comment in gforth.el:
; Byte-compile-Code rausschmeißen, Compilieren im Makefile über Emacs
; batch-Modus
A rough translation would be "get rid of byte-compile code, compile
via makefile using Emacs batch mode". This seems to indicate that the
original author(s) probably intended a change in the spirit of the
attached patch.
-- System Information:
Debian Release: wheezy/sid
APT prefers unstable
APT policy: (500, 'unstable'), (500, 'testing'), (1, 'experimental')
Architecture: amd64 (x86_64)
Kernel: Linux 3.5-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=C, LC_CTYPE=de_AT.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages gforth depends on:
ii dpkg 1.16.8
ii gforth-common 0.7.0+ds1-7
ii gforth-lib 0.7.0+ds1-7
ii install-info 4.13a.dfsg.1-10
ii libc6 2.13-35
ii libffcall1 1.10+cvs20100619-2
ii libltdl7 2.4.2-1.1
gforth recommends no packages.
gforth suggests no packages.
-- no debconf information
Index: gforth-0.7.0+ds1/gforth.el
===================================================================
--- gforth-0.7.0+ds1.orig/gforth.el 2012-08-15 00:29:28.156682885 +0200
+++ gforth-0.7.0+ds1/gforth.el 2012-08-15 00:30:13.856678664 +0200
@@ -1,6 +1,6 @@
;;; gforth.el --- major mode for editing (G)Forth sources
-;; Copyright (C) 1995,1996,1997,1998,2000,2001,2003,2004,2007,2008 Free Software Foundation, Inc.
+;; Copyright (C) 1995,1996,1997,1998,2000,2001,2003,2004,2007,2008,2012 Free Software Foundation, Inc.
;; This file is part of Gforth.
@@ -518,9 +518,7 @@
sub
))
mapped)))
- (let ((result (cons regexp sub-list)))
- (byte-compile 'result)
- result)))
+ (cons regexp sub-list)))
(defun forth-compile-words ()
"Compile the the words from `forth-words' and `forth-indent-words' into
@@ -734,13 +732,6 @@
(get-text-property from 'fontified))
(forth-update-properties from to)))))
-(eval-when-compile
- (byte-compile 'forth-set-word-properties)
- (byte-compile 'forth-next-known-forth-word)
- (byte-compile 'forth-update-properties)
- (byte-compile 'forth-delete-properties)
- (byte-compile 'forth-get-regexp-branch))
-
;;; imenu support
;;;
(defvar forth-defining-words
