On Wed, 26 Sep 2012 18:58:50 +0200, Andreas Beckmann wrote:

> Package: psad
> Version: 2.2-2
> Severity: serious
> Tags: squeeze-ignore
> User: debian...@lists.debian.org
> Usertags: piuparts
> Control: found -1 2.1.7-1
> 
> during a test with piuparts I noticed your package modifies conffiles.
> This is forbidden by the policy, see
> http://www.debian.org/doc/debian-policy/ch-files.html#s-config-files

> debsums reports modification of the following files,
> from the attached log (scroll to the bottom...):
> 
>   /etc/psad/psad.conf

Looks like #675231. The fix in -2 (set back the variable in preinst)
doesn't help against the underlying cause which is that the package
ships /etc/psad/psad.conf and then modifies it in postinst.

I think the way to go is:
- revert the change in preinst
- install psad.conf to /usr/share/psad/ or similar instead of
  /etc/psad
- copy it to /etc/psad if /etc/psad/psad.conf doesn't exist
- rm -f /etc/psad/psad.conf in postrm/purge

What makes me a bit unhappy is the unconditional replacing in
postinst; this will also overwrite any changes made by the admin. I
guess it could be limited to the case where the file still contains
_CHANGEME_, and (maybe, if this is necessary) to the case where the
current value doesn't match `hostname`.

Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Beach Boys: Darlin'

Attachment: signature.asc
Description: Digital signature

Reply via email to