-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I've checked your patch and have a few comments:
Is there a reason you put several commands in parallel in both clauses of an if statement? Specifically, I'm talking about the postrm script, the new purge block. Most of those lines can be outside the if AFAICS. The ifs in your new rm_* functions seem useless: you use rm -f anyway, so that doesn't fail if the target doesn't exist. That means the functions are really only one line; it would be possible (and a lot shorter) to put that line in the script instead of the function calls. Your changes to lib/log.lib.php and modules/captcha/captcha.php are not documented anywhere, and don't seem appropiate for a freeze exception. If they're really needed, please document them. "somethng weird has happened please restart the webserver manually" shoud be "Something weird has happened, please restart the webserver manually." If you reply by sunday, I can upload the new package for you. If you don't, I'll upload it with the above changed as indicated as NMU to the delayed queue. Thanks, Bas -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlB5QVMACgkQFShl+2J8z5XgfgCgwsspUIGWW99An1M5AjgnxFyN Sv4AoJGPL6oSYGHDDHPtEeOwwygdA1SW =vVrW -----END PGP SIGNATURE----- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
