Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package ruby-net-sftp The version 1:2.0.5-3 contains a fix for bug #674324, marked with severity serious. In the version currently in testing, some tests were failing, causing the package to FTBFS. It turns out that this is caused by a subtle bug in recent versions of ruby-mocha, inducing a conflict between some tests (this is now documented in #690562). Commenting one of the conflicting tests was sufficient to ensure the rest of test suite passes (all the tests, including that conflicting one, pass when run separately). The new version contains also some modifications of fields in debian/control (Conflicts → Breaks, and transitional packages marked with priority extra) to ensure a smooth upgrade from Squeeze libnet-sftp2-ruby* packages. Attached the debdiff against the version 1:2.0.5-2 currently in testing. Thank you in advance! Cédric unblock ruby-net-sftp/1:2.0.5-3 -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (990, 'unstable'), (500, 'testing'), (1, 'experimental') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash
diff -Nru ruby-net-sftp-2.0.5/debian/changelog ruby-net-sftp-2.0.5/debian/changelog --- ruby-net-sftp-2.0.5/debian/changelog 2011-05-20 18:12:20.000000000 +0200 +++ ruby-net-sftp-2.0.5/debian/changelog 2012-10-15 23:19:08.000000000 +0200 @@ -1,3 +1,16 @@ +ruby-net-sftp (1:2.0.5-3) unstable; urgency=medium + + * Team upload. + * Set urgency to medium, as this upload fixes an RC bug. + * Add debian/patches/disable_test_triggering_mocha_bug_690562.patch + to disable a test which, due to a bug in ruby-mocha, causes other tests + to fail, yielding a FTBFS (Closes: #674324). + * Ease upgrade from Squeeze libnet-sftp2-ruby* packages + + replace Conflicts: by Breaks: + + set priority of transitional packages to extra + + -- Cédric Boutillier <bou...@debian.org> Mon, 15 Oct 2012 22:16:06 +0200 + ruby-net-sftp (1:2.0.5-2) unstable; urgency=low * Add epoch to version in order to properly override the previous diff -Nru ruby-net-sftp-2.0.5/debian/control ruby-net-sftp-2.0.5/debian/control --- ruby-net-sftp-2.0.5/debian/control 2011-05-20 18:11:31.000000000 +0200 +++ ruby-net-sftp-2.0.5/debian/control 2012-10-15 23:19:31.000000000 +0200 @@ -16,7 +16,7 @@ XB-Ruby-Versions: ${ruby:Versions} Depends: ${shlibs:Depends}, ${misc:Depends}, ruby | ruby-interpreter, ruby-net-ssh Replaces: libnet-sftp-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby (<< 2.0.5-1~), libnet-sftp2-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby1.9.1 (<< 2.0.5-1~) -Conflicts: libnet-sftp-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby (<< 2.0.5-1~), libnet-sftp2-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby1.9.1 (<< 2.0.5-1~) +Breaks: libnet-sftp-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby (<< 2.0.5-1~), libnet-sftp2-ruby1.8 (<< 2.0.5-1~), libnet-sftp2-ruby1.9.1 (<< 2.0.5-1~) Provides: libnet-sftp-ruby1.8, libnet-sftp2-ruby, libnet-sftp2-ruby1.8, libnet-sftp2-ruby1.9.1 Description: Ruby implementation of the SFTP protocol Net::SFTP is a pure-Ruby implementation of the SFTP protocol (specifically, @@ -26,6 +26,7 @@ Package: libnet-sftp-ruby1.8 Section: oldlibs +Priority: extra Architecture: all Depends: ${misc:Depends}, ruby-net-sftp Description: Transitional package for ruby-net-sftp @@ -34,6 +35,7 @@ Package: libnet-sftp2-ruby Section: oldlibs +Priority: extra Architecture: all Depends: ${misc:Depends}, ruby-net-sftp Description: Transitional package for ruby-net-sftp @@ -42,6 +44,7 @@ Package: libnet-sftp2-ruby1.8 Section: oldlibs +Priority: extra Architecture: all Depends: ${misc:Depends}, ruby-net-sftp Description: Transitional package for ruby-net-sftp @@ -50,6 +53,7 @@ Package: libnet-sftp2-ruby1.9.1 Section: oldlibs +Priority: extra Architecture: all Depends: ${misc:Depends}, ruby-net-sftp Description: Transitional package for ruby-net-sftp diff -Nru ruby-net-sftp-2.0.5/debian/patches/disable_test_triggering_mocha_bug_690562.patch ruby-net-sftp-2.0.5/debian/patches/disable_test_triggering_mocha_bug_690562.patch --- ruby-net-sftp-2.0.5/debian/patches/disable_test_triggering_mocha_bug_690562.patch 1970-01-01 01:00:00.000000000 +0100 +++ ruby-net-sftp-2.0.5/debian/patches/disable_test_triggering_mocha_bug_690562.patch 2012-10-15 23:08:58.000000000 +0200 @@ -0,0 +1,26 @@ +Description: disable test causing FTBS because of a regression in ruby-mocha + After the expects call, :from_buffer method is not completely restored and + does not return objects from the correct class when applied to children + classes. +Author: Cédric Boutillier <bou...@debian.org> +Bug: http://net-ssh.lighthouseapp.com/projects/36253-net-ssh/tickets/62-net-sftp-fails-with-mocha-0113 +Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=674324 +Last-Update: 2012-10-15 + +--- a/test/protocol/01/test_base.rb ++++ b/test/protocol/01/test_base.rb +@@ -33,10 +33,10 @@ + assert_equal({ :data => "here is a string" }, @base.parse_data_packet(packet)) + end + +- def test_parse_attrs_packet_should_use_correct_attributes_class +- Net::SFTP::Protocol::V01::Attributes.expects(:from_buffer).with(:packet).returns(:result) +- assert_equal({ :attrs => :result }, @base.parse_attrs_packet(:packet)) +- end ++# def test_parse_attrs_packet_should_use_correct_attributes_class ++# Net::SFTP::Protocol::V01::Attributes.expects(:from_buffer).with(:packet).returns(:result) ++# assert_equal({ :attrs => :result }, @base.parse_attrs_packet(:packet)) ++# end + + def test_parse_name_packet_should_use_correct_name_class + packet = Net::SSH::Buffer.from(:long, 2, diff -Nru ruby-net-sftp-2.0.5/debian/patches/series ruby-net-sftp-2.0.5/debian/patches/series --- ruby-net-sftp-2.0.5/debian/patches/series 2011-05-17 22:03:58.000000000 +0200 +++ ruby-net-sftp-2.0.5/debian/patches/series 2012-10-15 22:43:43.000000000 +0200 @@ -1 +1,2 @@ disable-gem-in-tests.patch +disable_test_triggering_mocha_bug_690562.patch
signature.asc
Description: Digital signature