tags 682067 - patch tags 682067 + unreproducible retitle 682067 fai should deal with bare git repos thanks
Hi, On Donnerstag, 19. Juli 2012, Bastian Neuburger wrote: > When I use a git repository as config source for a FAI network install, > FAI exits after trying to setup the config space from git. > Inside /var/lib/fai there were not only the files I checked into the git > repo but also the git control files (e.g. HEAD, refs/). > Those should not be in /var/lib/fai but in /var/lib/fai/.git/ yes, they should. Seems your git repo is configured wrongly. (=as a bare git repo.) > IMO the clone command in get-config-dir-git should check out to > $GIT_DIR, see the patch at > https://github.com/bneuburg/fai/commit/1b567f8c6790176c142f8373446265fa9b4e > 00cf no, that patch is broken+wrong, as it breaks my (and several others) fai+git usage. $GIT_DIR is defined as $FAI/.git, and you really dont want your config space there, but in $FAI. So I recommend either closing this bug as a user error, or better, deal with bare repos, by either warning the user or handling them gracefully, if possible. cheers, Holger -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
