severity 693736 grave
thanks

I consider the severity grave as it causes data loss and makes the program
unusable for some/many users.

I attached the debdiff and uploaded the fixed version to mentors.debian.net:

http://mentors.debian.net/package/rawtherapee

Philip
diff -Nru rawtherapee-4.0.9/debian/changelog rawtherapee-4.0.9/debian/changelog
--- rawtherapee-4.0.9/debian/changelog  2012-06-21 18:31:45.000000000 +0200
+++ rawtherapee-4.0.9/debian/changelog  2012-11-19 21:11:56.000000000 +0100
@@ -1,3 +1,11 @@
+rawtherapee (4.0.9-4) unstable; urgency=low
+
+  * Fix RC bug that corrupts EXIF data in some cases (closes: #693736):
+     - add debian/patches/03-fix_exif_corruption.patch: Use the correct
+       size for multibyte EXIF tags which use TagDirectoryTable
+
+ -- Philip Rinn <ri...@gmx.net>  Mon, 19 Nov 2012 21:11:43 +0000
+
 rawtherapee (4.0.9-3) unstable; urgency=low
 
   * Fix upgrade failure to testing (closes: #677575).
diff -Nru rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch 
rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch
--- rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch       
1970-01-01 01:00:00.000000000 +0100
+++ rawtherapee-4.0.9/debian/patches/03-fix_exif_corruption.patch       
2012-11-19 19:38:27.000000000 +0100
@@ -0,0 +1,14 @@
+Author: Upstream
+Description: Use correct size on all multibyte EXIF tags which use 
TagDirectoryTable
+--- a/rtexif/rtexif.cc
++++ b/rtexif/rtexif.cc
+@@ -902,7 +902,7 @@
+       size += valuesize + (valuesize%2); // we align tags to even byte 
positions 
+ 
+    if (makerNoteKind!=NOMK) 
+-        count = directory[0]->calculateSize ();
++        count = directory[0]->calculateSize () / getTypeSize(type);
+         
+    if (makerNoteKind==NIKON3 || makerNoteKind==OLYMPUS2 || 
makerNoteKind==FUJI) 
+         size += valuesize;
+
diff -Nru rawtherapee-4.0.9/debian/patches/series 
rawtherapee-4.0.9/debian/patches/series
--- rawtherapee-4.0.9/debian/patches/series     2012-06-13 20:07:45.000000000 
+0200
+++ rawtherapee-4.0.9/debian/patches/series     2012-11-19 19:37:03.000000000 
+0100
@@ -1,2 +1,3 @@
 01-AboutThisBuild.patch
 02-fix_color_artifacts.patch
+03-fix_exif_corruption.patch

Reply via email to