Package: release.debian.org Severity: normal User: [email protected] Usertags: unblock
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi Release Team This is a pre-approval request for unblocking liblog-handler-perl 0.75-2 (note: not yet uploaded). I 'backported' the patch applied in upstream 0.76 to solve [1]. I know we are quite late, the upload can be done via unstable and the package is Priority: optional. [1]: https://rt.cpan.org/Public/Bug/Display.html?id=81155 The problem can be reproduced with this easy approach: - ----cut---------cut---------cut---------cut---------cut---------cut----- #!/usr/bin/perl use strict; use warnings; use DBI; use Log::Handler::Output::DBI; my $dbh = DBI->connect('DBI:mysql:dbname', 'user', 'password',); my $db = Log::Handler::Output::DBI->new( dbi_handle => $dbh, table => "messages", columns => [ qw/level ctime message/ ], values => [ qw/%level %time %message/ ], ); - ----cut---------cut---------cut---------cut---------cut---------cut----- resulting in: - ----cut---------cut---------cut---------cut---------cut---------cut----- root@sid:~# perl test.pl The following parameter was passed in the call to Log::Handler::Output::DBI::_validate but was not listed in the validation options: dbi_handle at /usr/share/perl5/Log/Handler/Output/DBI.pm line 444 Log::Handler::Output::DBI::_validate(undef, 'dbi_handle', 'DBI::db=HASH(0x1277f20)', 'table', 'messages', 'columns', 'ARRAY(0x1277d10)', 'values', 'ARRAY(0x1277ba8)', ...) called at /usr/share/perl5/Log/Handler/Output/DBI.pm line 296 Log::Handler::Output::DBI::new('Log::Handler::Output::DBI', 'dbi_handle', 'DBI::db=HASH(0x1277f20)', 'table', 'messages', 'columns', 'ARRAY(0x1277d10)', 'values', 'ARRAY(0x1277ba8)', ...) called at test.pl line 11 - ----cut---------cut---------cut---------cut---------cut---------cut----- I attached the proposed debdiff for the upload to unstable. Would it possible to get an unblock for it? Regards, Salvatore - -- System Information: Debian Release: wheezy/sid APT prefers unstable APT policy: (500, 'unstable'), (1, 'experimental') Architecture: amd64 (x86_64) Kernel: Linux 2.6.32-5-amd64 (SMP w/8 CPU cores) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/dash -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iQIcBAEBCgAGBQJQq66PAAoJEHidbwV/2GP+850QAM73SJb5/RZABywlbiWRdGPd kNTx3SLher9QogxaVKHBmwAOw9yPcKiy3GTcBIVPLp9VH54BG6Yahgtmvs8uHbyN 8Qyii+wKYB+20hWu/vMEFjULyk3Crw3VhpSrYPrHobSFl2UdidmB68pr4jnw3zaS 44wruYGTs2ZOwfsK/uKmQJjFhXMl9ncR66hgLL1oacYU3iUTD9MzlWG9s03UJyhI ceT6YoWJS9ugM/aM7HNFao0NsZ7qfv5GOwNx/s48u6oTPAqr4cEKwtp0Isg8H+V/ 5WTZAxtrz3XBLVTpmjOliWwDa7FteLoFXucZtoKr85LYn77ezaJwFB1hDLb8NDJN w3h+pGUrN/XRnd1K5j3znHLFTffX2P/OuCVSyRXIAB0uHyGHnE/7pFOA/vBRUIrU J2YrGSD6860cR3OTW/a4GsAoPyjwfSTULz8nf/NjbLPk+j4sczd9djTWMRx8ldVd okOubqZo3VrFFwFRrCgIroPlGdZPNlJNOEO8v2usly0D27no6+Jpn21Kj+AW1Jew 46oRJBwWUASC+TxByw2AiEfVr7EW87iw5GhzhSMqtruSwT9ORBuG6QeiH3TNehOi Xi1NmQD2AJ6zv9eVF6bWmx9ZcwhDsIt+zNU7OnRn1/tGCroBCIFys68bHrXhsBfx cnBzWxogEyZm3m0RmM6x =Ypaz -----END PGP SIGNATURE-----
diffstat for liblog-handler-perl-0.75 liblog-handler-perl-0.75 changelog | 8 +++ patches/0001-Fix-dbi_handle-validation-in-DBI.pm.patch | 38 +++++++++++++++++ patches/series | 1 3 files changed, 47 insertions(+) diff -Nru liblog-handler-perl-0.75/debian/changelog liblog-handler-perl-0.75/debian/changelog --- liblog-handler-perl-0.75/debian/changelog 2012-03-19 20:24:53.000000000 +0100 +++ liblog-handler-perl-0.75/debian/changelog 2012-11-20 17:12:18.000000000 +0100 @@ -1,3 +1,11 @@ +liblog-handler-perl (0.75-2) unstable; urgency=low + + * Add 0001-Fix-dbi_handle-validation-in-DBI.pm.patch patch. + Fix dbi_handle validation in Log::Handler::Output::DBI. + See https://rt.cpan.org/Public/Bug/Display.html?id=81155 + + -- Salvatore Bonaccorso <[email protected]> Tue, 20 Nov 2012 17:12:13 +0100 + liblog-handler-perl (0.75-1) unstable; urgency=low [ Ansgar Burchardt ] diff -Nru liblog-handler-perl-0.75/debian/patches/0001-Fix-dbi_handle-validation-in-DBI.pm.patch liblog-handler-perl-0.75/debian/patches/0001-Fix-dbi_handle-validation-in-DBI.pm.patch --- liblog-handler-perl-0.75/debian/patches/0001-Fix-dbi_handle-validation-in-DBI.pm.patch 1970-01-01 01:00:00.000000000 +0100 +++ liblog-handler-perl-0.75/debian/patches/0001-Fix-dbi_handle-validation-in-DBI.pm.patch 2012-11-20 17:12:18.000000000 +0100 @@ -0,0 +1,38 @@ +Description: Fix dbi_handle validation in DBI.pm +Origin: upstream +Bug: https://rt.cpan.org/Public/Bug/Display.html?id=81155 +Forwarded: not-needed +Author: Salvatore Bonaccorso <[email protected]> +Last-Update: 2012-11-19 + +--- + lib/Log/Handler/Output/DBI.pm | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) + +diff --git a/lib/Log/Handler/Output/DBI.pm b/lib/Log/Handler/Output/DBI.pm +index 33ecb4b..71bc1a0 100644 +--- a/lib/Log/Handler/Output/DBI.pm ++++ b/lib/Log/Handler/Output/DBI.pm +@@ -442,6 +442,10 @@ sub _validate { + my $class = shift; + + my %options = Params::Validate::validate(@_, { ++ dbi_handle => { ++ type => Params::Validate::OBJECT, ++ optional => 1, ++ }, + data_source => { + type => Params::Validate::SCALAR, + optional => 1, +@@ -535,7 +539,7 @@ sub _validate { + $cstr[0] .= ";port=$options{port}"; + } + } +- } else { ++ } elsif (!defined $options{dbi_handle}) { + Carp::croak "Missing mandatory options data_source or database/dbname"; + } + +-- +1.7.10.4 + diff -Nru liblog-handler-perl-0.75/debian/patches/series liblog-handler-perl-0.75/debian/patches/series --- liblog-handler-perl-0.75/debian/patches/series 1970-01-01 01:00:00.000000000 +0100 +++ liblog-handler-perl-0.75/debian/patches/series 2012-11-20 17:12:18.000000000 +0100 @@ -0,0 +1 @@ +0001-Fix-dbi_handle-validation-in-DBI.pm.patch
