Source: 9base Version: 6-5 Severity: important Tags: patch User: [email protected] Usertags: fcntl-fd-cloexec
Hi! This package contains code that tries to set the FD_CLOEXEC flag for a file descriptor, but it does using F_SETFL instead of F_SETFD. Using that value on F_SETFL is just wrong, and might make the call fail on some systems, as it's requesting to set an undetermined flag. For example on GNU/* FD_CLOEXEC has value 1, which matches with O_WRONLY. This might cause the code to at least leak file descriptors, and at worst to terminate execution. Attached a patch fixing this. Thanks, Guillem
From 7a4635f5b7afe6f39d86d36f68304f944cfe2285 Mon Sep 17 00:00:00 2001 From: Guillem Jover <[email protected]> Date: Tue, 18 Dec 2012 17:25:40 +0100 Subject: [PATCH] 9base: Set FD_CLOEXEC correctly using F_SETFD not F_SETFL Using that value on F_SETFL is just wrong, and might make the call fail on some systems, as it's requesting to set an undetermined flag. For example on GNU/* FD_CLOEXEC has value 1, which matches with O_WRONLY. This might cause the code to at least leak file descriptors, and at worst to terminate execution. --- lib9/create.c | 2 +- lib9/open.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib9/create.c b/lib9/create.c index e4e3c71..4d9ae10 100644 --- a/lib9/create.c +++ b/lib9/create.c @@ -67,7 +67,7 @@ out: } } if(cexec) - fcntl(fd, F_SETFL, FD_CLOEXEC); + fcntl(fd, F_SETFD, FD_CLOEXEC); if(rclose) remove(path); } diff --git a/lib9/open.c b/lib9/open.c index a0573ae..e21a5b4 100644 --- a/lib9/open.c +++ b/lib9/open.c @@ -54,7 +54,7 @@ p9open(char *name, int mode) } } if(cexec) - fcntl(fd, F_SETFL, FD_CLOEXEC); + fcntl(fd, F_SETFD, FD_CLOEXEC); if(rclose) remove(name); } -- 1.8.1.rc0
