On Mon, Dec 17, 2012 at 11:58 AM, Kartik Mistry <[email protected]>wrote:
> On Sat, Dec 15, 2012 at 2:39 PM, Pauli <[email protected]> wrote: > > I noticed that sometimes gwibber generates multiple notifications for a > > single update. I quickly figured out that issue was dbus starting > > multiple gwibber-service instances because a race condition in service > > startup. When I looked around I saw some Ubuntu bug report having > > similar issues with their indicator. I don't know if there is any more > > issues that are caused by the race condition. > > > > I have made a proposed fix to gwibber code and dbu service configuration > > to avoid the race condition in startup. The fix is simple refactoring > > dbus interface to be under single service name that allows dbus to > > provide atomic single service startup functionality for gwibber-service. > > > > I checked upstream code that same bug still exists in the latest > > development version. But I could easily compile the latest version in > > Sid so I decided to first cook a patch for the debian package. I will > > today forward port my changes for upstream inclusion. > > > > Attached patch will require also changes to packaging because it reduces > > .service files to only two. > > Thanks a lot. Can you redo patch against experimental package of > Gwibber? We really need to re-work on package as it has more > dependencies which are not in Debian yet. > > I will do that after Christmas. I didn't have time to figure out the build dependencies when I tried to build gwibber from upstream. I also opened upstream bug if someone there would like to forward port changes before I have time to figure out how to get required dependencies. https://bugs.launchpad.net/gwibber/+bug/1090670
