On Wed, 28 Nov 2012 08:19:25 +0100, Julien Cristau wrote: > > Severity: serious > > Justification: policy §9.1 (FHS: /var/lib is for state information not > > scripts), python policy §2.1 (module placement)
> > lastfmproxy ships a number of files in /var/lib that belong in /usr/share --
> > this includes python module files and probably also the png/html/css/js
> > files
> > as well.
> I don't think this warrants serious severity.
> > (Line 3 of the postinst also means that any debhelper boilerplate
> > added to the maintainer script will not be executed in a lot of cases
> > which is not as desirable.)
> This might.
#DEBHELPER# gets expanded to
# Automatically added by dh_installinit
if [ -x "/etc/init.d/lastfmproxy" ]; then
update-rc.d lastfmproxy defaults >/dev/null
invoke-rc.d lastfmproxy start || exit $?
fi
# End automatically added section
Interesting details re /var/lib vs. /usr/share:
- from postinst:
# 5. Remove old stuff..
if dpkg --compare-versions "$2" lt "1.2-1"; then
rm -rf /usr/share/lastfmproxy
usermod -d $HOME $LASTFMPROXY
fi
- from changelog:
* Moved working directory to /var/lib/lastfmproxy
Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - http://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Die Schmetterlinge: Feiertag
signature.asc
Description: Digital signature
