On Mon, Jan 14, 2013 at 04:33:44PM +0100, Sandro Tosi wrote: > Hi again, > > On Sun, Jan 13, 2013 at 5:16 PM, Sandro Tosi <[email protected]> wrote: > > I'll check it "for real" when I'll have a package to upload. > > I'm following the guide, and here are some notes (they are mainly > coming from my personal taste, so you can freely disagree and discard > them):
I highly doubt that I'd discard your input wholesale :) > > - i'd like more "dput-ng (<unique-id>)" so I created the app with that > name, it's pretty hidden so we can create the name as we prefer ACK. Not a bad idea. > - i'd remove the vetriol from "nonsense captcha" :) Yeah yeah, sorry :) It was an attempt to be funny. I'll fix that. > - given the OAuth token generated is specifically forged for the newly > created app, I don't think it's apporpriate to clutter ~ with another > hidden file with such a generic name like (.twitter.json), we can > either consider created it under ~/.config/dput-ng/ or in the > ~/.dput.d/ dir, like config or in the scripts subdir so that we can > read from it within the code - what do you think about it? > - would you consider moving the configuration for dput-ng under > ~/.config ? it's a new app, and the ~/.config is being populated by a > lot of new apps, so you might want to consider that too. So, yeah. We talked about this. It'd be fairly trivial to add that to the dput-ng "path", but there was some sort of discussion. Can't remember what. It's back on the stack. > - in twitter.json, I'd insert oauth_token before oauth_secret (at > least that's how it's proposed on the twitter page, so we can follow > that order here too) json objects are unordered, so that'd be fine :) > - s/name/description/ in tweet.json + it should contain the "post": > true => committed as 9224aea d'oh! That file predates that (and I think the "pre" / "post" syntax sucks anyway, we should have "order": "pre" or "order": "post" or something) Thanks for pushing the fix! > > It seems that's all, it worked! > https://twitter.com/sandrotosi/status/290842762088173568 :) \o/ > > Cheers, > -- > Sandro Tosi (aka morph, morpheus, matrixhasu) > My website: http://matrixhasu.altervista.org/ > Me at Debian: http://wiki.debian.org/SandroTosi Thanks for testing, Morph, Paul -- .''`. Paul Tagliamonte <[email protected]> : :' : Proud Debian Developer `. `'` 4096R / 8F04 9AD8 2C92 066C 7352 D28A 7B58 5B30 807C 2A87 `- http://people.debian.org/~paultag
signature.asc
Description: Digital signature
