Thanks for taking the time to send a patch. I appreciate it. On 12 February 2013 at 10:15, Andreas Beckmann wrote: | Package: r-base-core | Version: 2.15.2-1 | Severity: important | Tags: patch | | Hi, | | r-base-core excludes several files from md5sum computation. According to | the changelog this dates back to 1999 (the bug is no longer available in | the BTS) to work around some files being modified in some way or | another. But I cannot reproduce any such modification with a fresh | installation of current R. | | Therefore I'm attaching a patch that removes this legacy cruft and | includes md5sums for all files in the future.
In my defense, this was added a decade+ ago by the previous maintainer when md5sum was entirely optional. I think I touched it once and something promptly broke. | Not shipping md5sums defeats the purpose of tools like debsums: checking | for modifications by the local admin or due to hardware malfunction | (network, memory, disk, ...). | | There is one file being modified in the postinst script: Renviron.ucf. | That seems be be caused by some logic flaw originating from the time | when the configuration file in /etc was modified directly: | ## test if the file is unmodified `as shipped' | Renviron.ucf will be unmodified everytime (except when running | dpkg-reconfigure r-base-core), so the correct workflow for the postinst | should be something like | mktemp ; sed ; ucf ; rm | (generate default config from template in a temporary file, install this | via ucf, clean up afterwards). Likewise, I have no real interest (or time) in getting into conf file exercises-for-exercises sake debates. What we have now works, and A LOT of peope rely on this package. How precisely does your patch address this? Will we not trigger lots of false positives? Is there a way to avoid that? Dirk | | Andreas | | ---------------------------------------------------------------------- | diffstat for r-base_2.15.2-1 r-base_2.15.2-1.1 | | debian/r-base-core-dbg.lintian | 2 -- | r-base-2.15.2/debian/changelog | 7 +++++++ | r-base-2.15.2/debian/r-base-core.lintian | 15 --------------- | r-base-2.15.2/debian/rules | 11 ++--------- | 4 files changed, 9 insertions(+), 26 deletions(-) | | reverted: | --- r-base-2.15.2/debian/r-base-core-dbg.lintian | +++ r-base-2.15.2.orig/debian/r-base-core-dbg.lintian | @@ -1,2 +0,0 @@ | -r-base-core-dbg: file-missing-in-md5sums usr/lib/debug/usr/bin/Rscript | -r-base-core-dbg: file-missing-in-md5sums usr/lib/debug/usr/lib/R/bin/Rscript | diff -u r-base-2.15.2/debian/changelog r-base-2.15.2/debian/changelog | --- r-base-2.15.2/debian/changelog | +++ r-base-2.15.2/debian/changelog | @@ -1,3 +1,10 @@ | +r-base (2.15.2-1.1) unstable; urgency=low | + | + * Non-maintainer upload. | + * Stop excluding some files from md5sum computation. (Closes: #xxxxxx) | + | + -- Andreas Beckmann <[email protected]> Tue, 12 Feb 2013 02:24:39 +0100 | + | r-base (2.15.2-1) unstable; urgency=low | | * New upstream release | diff -u r-base-2.15.2/debian/rules r-base-2.15.2/debian/rules | --- r-base-2.15.2/debian/rules | +++ r-base-2.15.2/debian/rules | @@ -611,7 +611,7 @@ | dh_installdeb -i | #dh_perl -i | dh_gencontrol -i | - dh_md5sums -i -X'usr/bin/R' | + dh_md5sums -i | dh_builddeb -i | | # Build architecture-dependent files here. | @@ -653,8 +653,6 @@ | $(debbase)/$(recdpackage)/usr/share/lintian/overrides/$(recdpackage) | install -p -m 0644 debian/$(nmathpackage).lintian \ | $(debbase)/$(nmathpackage)/usr/share/lintian/overrides/$(nmathpackage) | - install -p -m 0644 debian/$(dbugpackage).lintian \ | - $(debbase)/$(dbugpackage)/usr/share/lintian/overrides/$(dbugpackage) | #dh_undocumented -a | dh_installchangelogs -a -k NEWS | # dh_strip -a | @@ -678,12 +676,7 @@ | # cat debian/r-recommended.substvars | # echo "*** Done ***" | dh_gencontrol -a | - dh_md5sums -a -X'usr/bin/R' -X'usr/bin/Rscript' \ | - -X'usr/lib/debug/usr/bin/Rscript' \ | - -X'usr/lib/R/bin/Rscript' \ | - -X'usr/lib/R/etc/Renviron.ucf' \ | - -XLibIndex -Xindex.txt \ | - -Xfunction.html -Xpackages.html | + dh_md5sums -a | dh_builddeb -a | | #binary: binary-indep binary-arch install-arch install-indep | diff -u r-base-2.15.2/debian/r-base-core.lintian r-base-2.15.2/debian/r-base-core.lintian | --- r-base-2.15.2/debian/r-base-core.lintian | +++ r-base-2.15.2/debian/r-base-core.lintian | @@ -2,21 +2,6 @@ | r-base-core: shlib-with-non-pic-code usr/lib/R/modules/lapack.so | r-base-core: shlib-with-non-pic-code usr/lib/R/modules/vfonts.so | r-base-core: shlib-with-non-pic-code usr/lib/R/library/modreg/libs/modreg.so | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/html/function.html | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/html/is.function.html | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/html/remove.packages.html | -r-base-core: file-missing-in-md5sums usr/lib/R/doc/html/function.html | -r-base-core: file-missing-in-md5sums usr/share/R/doc/html/packages.html | -r-base-core: file-missing-in-md5sums usr/share/R/doc/html/search/index.txt | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/html/as.function.html | -r-base-core: file-missing-in-md5sums usr/bin/R | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/html/update.packages.html | -r-base-core: file-missing-in-md5sums usr/lib/R/library/base/help/make.packages.html | -r-base-core: file-missing-in-md5sums usr/lib/R/library/utils/help/make.packages.html | -r-base-core: file-missing-in-md5sums usr/bin/Rscript | -r-base-core: file-missing-in-md5sums usr/lib/R/library/utils/R-ex/make.packages.html.R | -r-base-core: file-missing-in-md5sums usr/lib/R/bin/Rscript | -r-base-core: file-missing-in-md5sums usr/lib/R/etc/Renviron.ucf | r-base-core: extra-license-file usr/lib/R/library/base/help/license | r-base-core: image-file-in-usr-lib usr/lib/R/doc/html/left.jpg | r-base-core: image-file-in-usr-lib usr/lib/R/doc/html/logo.jpg -- Dirk Eddelbuettel | [email protected] | http://dirk.eddelbuettel.com -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
