On Mon, Feb 18, 2013 at 3:27 PM, Marco Schuster <ma...@m-s-d.eu> wrote:
> On Mon, Feb 18, 2013 at 3:23 PM, Miklos Szeredi <mik...@szeredi.hu> wrote:
>> On Sun, Feb 17, 2013 at 11:49 PM, Marco Schuster <ma...@m-s-d.eu> wrote:
>>> In the source file lib/fuse_opt.c, the function process_opt_param leaks
>>> memory by silently overwriting *(char **) var = copy; in line 218.
>>
>> That's true.   But there's a "but".  The previous value may not have
>> been initialized and then we may not be able to free it.  The app is
>> probably broken at that point anyway, yet we don't want to make it
>> more broken.
>
> I found out about this as PHP tracks the memory it allocated with its
> own emalloc and friends and complains when you don't call efree() on
> them all. But I don't see any way to fix this for real, as every
> external application can use its own memory/heap allocator...
>
> Marco

Added this patch to 3.0.

Thanks,
Miklos

Attachment: fuse_opt_parse-fix-memory-leak.patch
Description: Binary data

Reply via email to