Followup-For: Bug #700789
Control: tag -1 pending
Hi,
uploaded with two minor fixes to DELAYED/3:
* also remove a leftover empty /usr/share/autoconf-archive
* make the preinst actually work: remove trailing slash from path
test -L /path/to/link/
will never return 'true' because the trailing slash causes a symlink
to be followed
In general I'd not add the boilerplate comments to maintainer scripts,
and the final 'exit 0' is also useless in a script that uses 'set -e'.
And maybe the preinst could have been restricted to
if [ "$1" = "install" ] || [ "$1" = "upgrade" ]
But I really liked the comments you added, especially setting a expiry
date for the cleanup code :-)
To avoid requesting yet another upload from you to mentors with just my
patch applied, I uploaded the package with these fixes to DELAYED/3 - so
you have chance to review, comment, and change things again.
But if there is no further action required, the package will be
automatically "uploaded" in 3 days (e.g. once the delay has expired).
Andreas
diffstat for autoconf-archive-20111221 autoconf-archive-20111221
autoconf-archive.postinst | 3 ++-
autoconf-archive.preinst | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff -Nru autoconf-archive-20111221/debian/autoconf-archive.postinst autoconf-archive-20111221/debian/autoconf-archive.postinst
--- autoconf-archive-20111221/debian/autoconf-archive.postinst 2013-02-18 22:22:47.000000000 +0100
+++ autoconf-archive-20111221/debian/autoconf-archive.postinst 2013-02-20 01:24:39.000000000 +0100
@@ -9,6 +9,7 @@
# remove after squeeze + 2
if [ -d $OLDHTMLDOCDIR ]; then
rm -rf $OLDHTMLDOCDIR
+ rmdir /usr/share/autoconf-archive 2>/dev/null || true
fi
@@ -17,4 +18,4 @@
#DEBHELPER#
-exit 0
\ No newline at end of file
+exit 0
diff -Nru autoconf-archive-20111221/debian/autoconf-archive.preinst autoconf-archive-20111221/debian/autoconf-archive.preinst
--- autoconf-archive-20111221/debian/autoconf-archive.preinst 2013-02-18 22:22:47.000000000 +0100
+++ autoconf-archive-20111221/debian/autoconf-archive.preinst 2013-02-20 01:25:25.000000000 +0100
@@ -2,7 +2,7 @@
set -e
-HTMLDOCDIR=/usr/share/doc/autoconf-archive/html/
+HTMLDOCDIR=/usr/share/doc/autoconf-archive/html
# fix bug 700789
# remove old squeeze symlink
@@ -16,4 +16,4 @@
#DEBHELPER#
-exit 0
\ No newline at end of file
+exit 0
