Package: udev
Version: 175-7
Severity: normal
Tags: patch

Hi,
in order to determine the orientation of the device it picks the wrong
device. It picked the "Asus Laptop extra buttons" instead of the
accelerometer. This is a straight backport from upstream commit
1d010426c01044350b2b32d8b3af5d064f7dfe27.

It would be awesome to have this in an updated version of udev. 
Cheers,
 -- Guido


-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (990, 'testing'), (50, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages udev depends on:
ii  debconf [debconf-2.0]  1.5.49
ii  libc6                  2.13-37
ii  libselinux1            2.1.9-5
ii  libudev0               175-7
ii  lsb-base               4.1+Debian8
ii  procps                 1:3.3.3-2
ii  util-linux             2.20.1-5.3

Versions of packages udev recommends:
ii  pciutils  1:3.1.9-6
ii  usbutils  1:005-3

udev suggests no packages.

-- debconf information excluded
>From 701b112723dabd7ffb9a71cacfd45d0545bffa2b Mon Sep 17 00:00:00 2001
From: Guido Günther <a...@sigxcpu.org>
Date: Sat, 23 Feb 2013 09:05:23 +0100
Subject: [PATCH] Fix device naming in the accelerometer

---
 .../fix_device_matching_in_the_accelerometer       |   37 ++++++++++++++++++++
 debian/patches/series                              |    1 +
 2 files changed, 38 insertions(+)
 create mode 100644 debian/patches/fix_device_matching_in_the_accelerometer

diff --git a/debian/patches/fix_device_matching_in_the_accelerometer b/debian/patches/fix_device_matching_in_the_accelerometer
new file mode 100644
index 0000000..1954afe
--- /dev/null
+++ b/debian/patches/fix_device_matching_in_the_accelerometer
@@ -0,0 +1,37 @@
+From: Guido Günther <a...@sigxcpu.org>
+Date: Sat, 23 Feb 2013 08:45:50 +0100
+Subject: Fix device matching in the accelerometer
+
+As we were searching by ID_PATH, it would have been possible
+for us to find a sibling device instead of the device we were
+looking for.
+
+This fixes device matching on the WeTab with the upstream kernel,
+as it was trying to use the "Asus Laptop extra buttons" device
+instead of the accelerometer.
+
+Backported version of 1d010426c01044350b2b32d8b3af5d064f7dfe27
+---
+ extras/accelerometer/accelerometer.c |    7 ++-----
+ 1 file changed, 2 insertions(+), 5 deletions(-)
+
+diff --git a/extras/accelerometer/accelerometer.c b/extras/accelerometer/accelerometer.c
+index 59c2a4e..b8de3e0 100644
+--- a/extras/accelerometer/accelerometer.c
++++ b/extras/accelerometer/accelerometer.c
+@@ -307,13 +307,10 @@ int main (int argc, char** argv)
+ 		return 0;
+ 	}
+ 
+-	/* Get the children devices and find the devnode
+-	 * FIXME: use udev_enumerate_add_match_children() instead
+-	 * when it's available */
++	/* Get the children devices and find the devnode */
+ 	devnode = NULL;
+ 	enumerate = udev_enumerate_new(udev);
+-	udev_enumerate_add_match_property(enumerate, "ID_PATH", id_path);
+-	udev_enumerate_add_match_subsystem(enumerate, "input");
++	udev_enumerate_add_match_parent(enumerate, dev);
+ 	udev_enumerate_scan_devices(enumerate);
+ 	udev_list_entry_foreach(list_entry, udev_enumerate_get_list_entry(enumerate)) {
+ 		struct udev_device *device;
diff --git a/debian/patches/series b/debian/patches/series
index ddd85b2..dfe9f0d 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -23,3 +23,4 @@ use_run_tmpfs
 dev_root_rule
 udevd_in_sbin
 udev_conf_comments
+fix_device_matching_in_the_accelerometer
-- 
1.7.10.4

Reply via email to