Package: debhelper
Version: 9.20120909
Severity: wishlist
Tags: patch

Dear Maintainer,

Some packages default to -DCMAKE_BUILD_TYPE=Release, or their maintainers 
choose to set that flag in debian/rules, thus producing binaries compiled with
-O3 -DNDEBUG. As discussed on debian-devel [1], this isn't ideal. Instead,
we should be promoting the use of -DCMAKE_BUILD_TYPE=RelWithDebInfo (-g -O2),
and here's a patch that does that.

diff --git a/Debian/Debhelper/Buildsystem/cmake.pm 
b/Debian/Debhelper/Buildsystem/cmake.pm
index 1d009b4..d47821c 100644
--- a/Debian/Debhelper/Buildsystem/cmake.pm
+++ b/Debian/Debhelper/Buildsystem/cmake.pm
@@ -43,6 +43,7 @@ sub configure {
        # Standard set of cmake flags
        push @flags, "-DCMAKE_INSTALL_PREFIX=/usr";
        push @flags, "-DCMAKE_VERBOSE_MAKEFILE=ON";
+       push @flags, "-DCMAKE_BUILD_TYPE=RelWithDebInfo";
 
        # CMake doesn't respect CPPFLAGS, see #653916.
        if ($ENV{CPPFLAGS} && ! compat(8)) {

Regards,
Vincent

[1] https://lists.debian.org/debian-devel/2013/02/msg00124.html

-- System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (700, 'testing'), (500, 'unstable'), (200, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.6.8-1-vclaptop-amd64 (SMP w/8 CPU cores; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages debhelper depends on:
ii  binutils    2.22-7.1
ii  dpkg        1.16.9
ii  dpkg-dev    1.16.9
ii  file        5.11-2
ii  html2text   1.3.2a-15
ii  man-db      2.6.2-1
ii  perl        5.14.2-18
ii  po-debconf  1.0.16+nmu2

debhelper recommends no packages.

Versions of packages debhelper suggests:
ii  dh-make  0.61

-- no debconf information


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org

Reply via email to