On 03/09/12 at 19:13 +0200, Francesco Poli (wintermute) wrote:
> Package: packaging-tutorial
> Version: 0.7
> Severity: minor
> 
> Hi Lucas,
> I am more or less half-way in my reading of the packaging tutorial.
> What follows is a list of suggestions, corrections, enhancements, and
> so forth, grouped by relevant slide.
> 
> I hope this may be useful to you, in order to further improve the
> tutorial and let it become even better than it currently is!

Hi,

Thanks a lot for all the feedback. Very useful indeed.

> Slide 1
> -------
> 
> The version number shown in the title slide should be generated
> automatically during the package build, so that discrepancies between
> this number and the package version may be avoided.  In the present
> case, the package version is 0.7, but the title slide says that the
> tutorial version is 0.6, which is very confusing...

fixed

> Slide 8
> -------
> 
> | on the developers' machine
> 
> I think that this is not really correct: "machine" is singular, hence
> I suppose that "developers'", which is plural, should be turned into
> singular ("developer's"), since we are talking about the machine of
> one developer, not about the machine of all the developers...

fixed

> Slide 12
> --------
> 
> | 1.0 ­ native: package_version.tar.gz
> 
> Actually this holds for 3.0 (native) as well...
> As a consequence, I would
> 
> s/1.0 ­ native/1.0 or 3.0 (native)/
> 
> Maybe, just to get a more uniform looking list, you could also
> 
> s/1.0 ­ non-native/1.0 (non-native)/
> 
> in the following list item...

fixed

> Slide 15
> --------
> 
> I think that an additional step should be recommended between
> "untar it" and "cd upstream_source":
> 
>  » rename the directory to <source_package>-<upstream_version>
>    (example: simgrid-3.6)
> 
> Consequently, the following steps should become:
> 
>  » cd <source_package>-<upstream_version> && dh_make
>    (from the dh-make package)

fixed

> Slide 35
> --------
> 
> I suggest you to add a mini-tutorial on "dpkg-source --commit"
> and other options or commands that enable a user to manage
> patches in "3.0 (quilt)" format packages, without the need to
> install quilt...

I'll file a separate bug for that

> Slide 36
> --------
> 
> After this slide there should be (at least) one slide dedicated
> to the cases where the upstream source archive must be re-packed,
> for instance because some non-free parts have to be dropped,
> or because some convenience copy of a library should be removed
> in favor of the packaged version.
> How should this be done?  Please explain.

And for that too

Lucas


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to