Package: git-stuff
Version: 15-1
Severity: normal
Tags: patch

The scripts git-hook-notification-email and git-hook-notification-bts are still using the command repo-config, which has been officially deprecated in version 1.5.4 of Git. For instance, when using the former script for automatic email notification of repository activity, I get several times the following warning message:

    remote: WARNING: git repo-config is deprecated in favor of git config.

The trivial patch for fixing the problem is attached below.

Best,

Rafael Laboissière


--
System Information:
Debian Release: 7.0
  APT prefers testing
  APT policy: (650, 'testing'), (600, 'unstable'), (550, 'stable'), (500, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 3.2.0-4-686-pae (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

--
Versions of packages git-stuff depends on:
ii  debconf [debconf-2.0]  1.5.49
ii  git                    1:1.7.10.4-1+wheezy1

--
Versions of packages git-stuff recommends:
ii  cron              3.0pl1-124
ii  git-buildpackage  0.6.0~git20120601
ii  mr                1.12
ii  pristine-tar      1.25

--
Versions of packages git-stuff suggests:
pn  gitstats  <none>
pn  irker     <none>

--
debconf information:
  git-stuff/bash-profile: false
  git-repack-repositories/cron: @monthly
  git-repack-repositories/enable: false
  git-repack-repositories/title:
  git-stuff/title:
  git-repack-repositories/directories: /srv/git









diff -Naur a/git-hook-notification-bts b/git-hook-notification-bts
--- a/git-hook-notification-bts	2013-03-06 19:09:11.000000000 +0100
+++ b/git-hook-notification-bts	2013-03-06 19:10:08.000000000 +0100
@@ -19,12 +19,12 @@
 set -u
 
 REPODIR=`readlink -f "$PWD"`
-PROJECTROOT=`git repo-config hooks.projectroot`
+PROJECTROOT=`git config hooks.projectroot`
 REPOREL=${REPODIR#$PROJECTROOT}
 REPOREL=${REPODIR#/srv/git.debian.org/git/}
 REPOREL=${REPOREL#/srv/alioth.debian.org/chroot/home/}
 REPOREL=${REPOREL/\/public_git\//\/}
-BASEURL="`git repo-config hooks.baseurl`"
+BASEURL="`git config hooks.baseurl`"
 BASEURL="${BASEURL:-http://git.debian.org/}";
 BASEURL="${BASEURL}?p=$REPOREL"
 
diff -Naur a/git-hook-notification-email b/git-hook-notification-email
--- a/git-hook-notification-email	2013-03-06 19:09:11.000000000 +0100
+++ b/git-hook-notification-email	2013-03-06 19:09:55.000000000 +0100
@@ -648,13 +648,13 @@
 	projectdesc="UNNAMED PROJECT"
 fi
 
-recipients=$(git repo-config hooks.mailinglist)
-bcc_recipients=$(git repo-config hooks.bcc)
-reply_to=$(git repo-config hooks.replyto)
-announcerecipients=$(git repo-config hooks.announcelist)
-envelopesender=$(git repo-config hooks.envelopesender)
+recipients=$(git config hooks.mailinglist)
+bcc_recipients=$(git config hooks.bcc)
+reply_to=$(git config hooks.replyto)
+announcerecipients=$(git config hooks.announcelist)
+envelopesender=$(git config hooks.envelopesender)
 sendmail="/usr/sbin/sendmail -t"
-subjectdesc=$(git repo-config hooks.subjectdesc)
+subjectdesc=$(git config hooks.subjectdesc)
 
 if [ -z "$subjectdesc" ]; then
 	subjectdesc=$projectdesc

Reply via email to