Source: colord
Version: 0.1.31-1
Severity: serious
Tags: patch
Justification: fails to build from source

Hi,

the new colord 0.1.31-1 cannot be built on non-Linux archs because of
the libsystemd-login-dev B-D (built from systemd, which is
Linux-specific).

Other than that, there are other issues, which my patch fixes in
(I hope) a clean way:
- as said already, limit the libsystemd-login-dev B-D as linux-any
- gusb and systemd-login are Linux-specific, so explicitly enable or
  disable them on Linux archs or not
- since the udev directory cannot be detected, on non-Linux archs the
  installation path of the udev rules would result as "/rules.d".
  To avoid this, I've explicitly set the udevdir to configure (also on
  Linux); of course, if this seems notdesiderable, the udevdir can be
  passed only on non-Linux archs
- the colorhug stuff depends on gusb, so all the colorhug packages are
  now linux-any instead of any
- there seem to be no colord-plugins compiled, so its line in
  colord.install would result in a dh_install error; I've "grouped" it
  with the colord-sensors line that follows in that .install file,
  I hope it is not too generic now

Thanks,
-- 
Pino
--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,7 @@ Build-Depends:
  dh-autoreconf,
  gtk-doc-tools,
  autopoint,
- libsystemd-login-dev,
+ libsystemd-login-dev [linux-any],
 Standards-Version: 3.9.4
 XS-Testsuite: autopkgtest
 Section: graphics
@@ -101,7 +101,7 @@ Description: GObject introspection data
 
 Package: libcolorhug-dev
 Section: libdevel
-Architecture: any
+Architecture: linux-any
 Depends: 
  libcolorhug1 (= ${binary:Version}),
  libglib2.0-dev,
@@ -119,7 +119,7 @@ Description: library to access the Color
 
 Package: libcolorhug1
 Section: libs
-Architecture: any
+Architecture: linux-any
 Depends: 
  ${shlibs:Depends},
  ${misc:Depends},
@@ -135,7 +135,7 @@ Description: library to access the Color
 
 Package: gir1.2-colorhug-1.0
 Section: introspection
-Architecture: any
+Architecture: linux-any
 Depends: ${gir:Depends},
          ${shlibs:Depends},
          ${misc:Depends}
--- a/debian/rules
+++ b/debian/rules
@@ -21,12 +21,13 @@ confflags = \
  --disable-volume-search \
  --with-daemon-user=colord \
  --with-systemdsystemunitdir=/lib/systemd/system \
+ --with-udevrulesdir=/lib/udev/rules.d \
  --enable-vala
 
 ifeq ($(DEB_HOST_ARCH_OS),linux)
-	confflags += --enable-gudev --enable-sane
+	confflags += --enable-gudev --enable-sane --enable-gusb --enable-systemd-login
 else
-	confflags += --disable-gudev --disable-sane
+	confflags += --disable-gudev --disable-sane --disable-gusb --disable-systemd-login
 endif
 
 override_dh_auto_configure:
--- a/debian/colord.install
+++ b/debian/colord.install
@@ -2,8 +2,7 @@ debian/tmp/etc/
 lib/udev/rules.d/
 usr/bin/
 usr/lib/colord*
-usr/lib/*/colord-plugins
-usr/lib/*/colord-sensors
+usr/lib/*/colord-*
 usr/share/color
 usr/share/colord
 usr/share/glib-2.0/schemas

Reply via email to