Package: ebtables
Version: 2.0.10.4-2ubuntu1
Severity: minor
Tags: patch

Hi,

We just uploaded a package based on ebtables 2.0.10.4-2 to Ubuntu.
Upgrades started failing with

,----
| Setting up ebtables (2.0.10.4-2ubuntu1) ...
| Installing new version of config file /etc/init.d/ebtables ...
| update-rc.d: error: start|stop arguments not terminated by "."
| usage: update-rc.d [-n] [-f] <basename> remove
|        update-rc.d [-n] <basename> defaults [NN | SS KK]
|        update-rc.d [-n] <basename> start|stop NN runlvl [runlvl] [...] .
|        update-rc.d [-n] <basename> disable|enable [S|2|3|4|5]
|                 -n: not really
|                 -f: force
| 
| The disable|enable API is not stable and might change in the future.
| dpkg: error processing ebtables (--configure):
|  subprocess installed post-installation script returned error exit status 1
`----

There is no error or warning in Debian, presumably due to differences in
sysvinit (hence the severity).

But you can see in the usage message there that the terminating '.' should be
included.

Patch attached.

Cheers!

-- 
Iain Lane                                  [ [email protected] ]
Debian Developer                                   [ [email protected] ]
Ubuntu Developer                                   [ [email protected] ]
diff -Nru ebtables-2.0.10.4/debian/changelog ebtables-2.0.10.4/debian/changelog
--- ebtables-2.0.10.4/debian/changelog	2013-03-20 16:30:15.000000000 +0000
+++ ebtables-2.0.10.4/debian/changelog	2013-05-05 20:11:30.000000000 +0100
@@ -1,3 +1,9 @@
+ebtables (2.0.10.4-3) UNRELEASED; urgency=low
+
+  * Fix update-rc.d call to include trailing ".". 
+
+ -- Iain Lane <[email protected]>  Sun, 05 May 2013 20:11:07 +0100
+
 ebtables (2.0.10.4-2) unstable; urgency=low
 
   * packaging update:
diff -Nru ebtables-2.0.10.4/debian/rules ebtables-2.0.10.4/debian/rules
--- ebtables-2.0.10.4/debian/rules	2013-03-15 14:21:39.000000000 +0000
+++ ebtables-2.0.10.4/debian/rules	2013-05-05 20:11:07.000000000 +0100
@@ -10,7 +10,7 @@
 CFLAGS+=$(HARDENING_CFLAGS) -fstack-protector-all
 LDFLAGS+=$(HARDENING_LDFLAGS)
 
-DEB_DH_INSTALLINIT_ARGS:=-- start 20 S . stop 80 0 1 6
+DEB_DH_INSTALLINIT_ARGS:=-- start 20 S . stop 80 0 1 6 .
 
 build/ebtables::
 	make CFLAGS="$(CFLAGS)" $(MAKE_PATH_REDIRECTIONS)

Reply via email to