Ansgar Burchardt wrote: > binNMUs for multiarch packages are currently broken as the changelog > will differ between architectures. There are several options to fix this > (split changelog, move changelog from usr/share/doc to DEBIAN/), however > there doesn't seem to be a consensus on the final solution yet.
Isn't this just a special case of the larger problem that multiarch
falls over when any shared file varies, including other files in /usr/share/doc?
It seems odd that none of these proposed solutions deal with the larger
problem.
> +sub install_changelog
> +{
> + my ($package, $input_fn, $changelog_name) = @_;
<snip 41 lines>
This is not following debhelper's code formatting style.
It's also not following debhelper's design to put such a lot of code into
a debhelper command. This deserves to be its own utility, which
dh_installchangelogs can run, and packages not using debhelper could also run.
dpkg-dev seems a good place to put such a thing.
Not that I want to put up roadblocks to a pragmatic fix getting in place.
> + while (my $line = <$input>) {
> + if ($line =~ /\A\S.*;.*\bbinary-only=yes/) {
Considering the length of some changelogs, and that this should only
ever appear on the first line of the file, this is a pretty inneficcient
implementation. It could be sped up a lot I think by just checking the first
line and falling back to the current copy method.
--
see shy jo
signature.asc
Description: Digital signature
