Dear maintainer(s),

As far as I can tell, the xdeb check is more outdated than that
suggested by the reporter.

All the $tags->suppress are not useful/reliable.  As it is, Lintian will
sort all checks by name and run them in that order.  Accordingly, all of
Lintian's core checks will have been run at least once before xdeb has a
chance to disable them.  Here xdeb should use a profile instead of
messing the suppress method.
  With the "suppress" calls removed, it looks like xdeb can be reduced
to a binary/udeb-only check.

"sort keys %{$info->file_info}" will not work anymore.  The call to
file_info will return undef.  Here, "sort keys ..." should be replaced
by $info->sorted_index (requires a Needs-Info on index) followed by a
"$info->file_info($file)" look up[1].
  As I recall, this remark applies regardless of whether Lintian 2.5.12
or 2.5.10 is used (but I could be wrong irt. 2.5.10).  Should I be
wrong, the current code should still apply with 2.5.10, but will be
broken as soon as a new version of Lintian based on 2.5.12 is uploaded
to sid.

The %archdetecttable is appears to be (mostly) a copy of a data file
Lintian carries atm[2].  From what I gather Lintian stole it from
c/emdebian (which might have stolen it from xdeb).  So it may (or may
not) be easier for you to simply outsource the maintenance of that list
to Lintian.

Thank you for using Lintian as basis for your static analysis checks, :)
~Niels

[1] i.e. "->{" is replaced with "(" and "}" with ")".

[2] The data file is called binaries/arch-regex.  It is used in
checks/binaries, in case an example is needed.


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to