Hi,
Josh Stone <jist...@redhat.com> writes:
> Note, there are actually a few commits associated with PR 14245:
thanks for letting me know.
> 17986f2 PR14245 stapio should not pass inherited relay_basedir_fd
Right, I can see an extra file descriptor being open:
$ stap -e 'probe begin {}' -c "ls -l /proc/self/fd"
WARNING: side-effect-free probe 'probe_1987': keyword at <input>:1:1
source: probe begin {}
^
total 0
lrwx------ 1 lindi kurp 64 May 23 09:06 0 -> /dev/pts/1
lrwx------ 1 lindi kurp 64 May 23 09:06 1 -> /dev/pts/1
lrwx------ 1 lindi kurp 64 May 23 09:06 2 -> /dev/pts/1
lr-x------ 1 lindi kurp 64 May 23 09:06 3 ->
/sys/kernel/debug/systemtap/stap_eeae76802d0a6271e55c3f687cef638_4280
lr-x------ 1 lindi kurp 64 May 23 09:06 4 -> /proc/4281/fd
Could this be a security issue? Could it cause otherwise buggy behavior?
> d7f9b5d PR14245 clean up error messages for staprun -d SOMETHING_AWFUL
Is this only a cosmetic issue of printing the wrong error message?
> 00d577a PR14245: fix staprun->stapio -F<fd> passing for -A (attach) mode
This seems to fortunately still work as root so no regression was
introduced in the backport:
$ stap -v -p4 -e 'probe timer.ms(1000) { printf("hello\n"); }'
Pass 1: parsed user script and 81 library script(s) using
79728virt/22236res/2424shr kb, in 90usr/20sys/111real ms.
Pass 2: analyzed script: 1 probe(s), 0 function(s), 0 embed(s), 0 global(s)
using 80260virt/23028res/2560shr kb, in 0usr/0sys/4real ms.
/home/lindi/.systemtap/cache/69/stap_6940b8229bf7950f1e2d880991495fa9_593.ko
Pass 3: using cached
/home/lindi/.systemtap/cache/69/stap_6940b8229bf7950f1e2d880991495fa9_593.c
Pass 4: using cached
/home/lindi/.systemtap/cache/69/stap_6940b8229bf7950f1e2d880991495fa9_593.ko
lindi2:~$ staprun -L
/home/lindi/.systemtap/cache/69/stap_6940b8229bf7950f1e2d880991495fa9_593.ko
Disconnecting from systemtap module.
To reconnect, type "staprun -A stap_6940b8229bf7950f1e2d880991495fa9_593"
lindi2:~$ staprun -A stap_6940b8229bf7950f1e2d880991495fa9_593
ERROR: no access to debugfs; try "chmod 0755 /sys/kernel/debug" as root
Failed to initialize control channel.
lindi2:~$ sudo staprun -A stap_6940b8229bf7950f1e2d880991495fa9_593
hello
hello
hello
hello
hello
hello
hello
hello
hello
hello
hello
hello
hello
hello
> 56629dd PR14245: have configury look for openat(2) syscall
This should not be needed since the backported patch does not use
"#ifdef HAVE_OPENAT".
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
