So it seems those libraries are put there by upstream and are necessary because they are patched:
09:50:40 <anarcat> there are a bunch of compiler warnings when compiling darktable 09:50:54 <anarcat> but precisely, there are warnings in src/external/LibRaw 09:50:59 <anarcat> https://buildd.debian.org/status/fetch.php?pkg=darktable&arch=i386&ver=1.2-1&stamp=1367788623 09:51:16 <anarcat> but the rest of darktable is impressively warning-clean 09:53:40 <christte> darktable is compiled with treat warnings as errors gcc flag 09:53:48 <christte> so no warnings are allowed 09:54:01 <christte> the warnings you see are from external libraries 09:55:20 <anarcat> yeah, i understand 09:55:29 <anarcat> i was surprised to see the debian package compile externabl libraries 09:55:40 <anarcat> normally this is against the rules: it should use the existing libraries 09:56:36 <jcsogo> yes, I am not happy that we need to incorporate external libraries 10:02:00 <hanatos> we patch it 10:02:07 <hanatos> it's not libraw, but something similar 10:02:15 <hanatos> (we don't patch away the compiler warnings though) 10:02:23 <hanatos> they removed a couple of essential features 10:02:28 <hanatos> like float-valued dng 10:02:36 <hanatos> and document mode (no demosaicing) 10:02:41 <hanatos> in the long run it should probably go away completely 10:05:35 <jcsogo> ditch libraw for 1.6 :) 10:05:48 <jcsogo> who needs that? 10:06:10 <hanatos> seriously 10:06:17 <hanatos> some old edge case cameras 10:06:22 <hanatos> and we read whitebalance using it 10:06:31 <hanatos> (there should really be an exiv2 wrapper, probably there is actually) 10:06:36 * hanatos checks 10:07:56 <anarcat> it would be nice if this would be merged upstream and yes, those become dependencies 10:08:15 <anarcat> i opened an issue with the debian package and copy-paste this conversation if you don't mind 10:10:26 <hanatos> nonono 10:10:27 <hanatos> :) 10:10:32 <hanatos> upstream removed those things 10:10:41 <hanatos> we revert a couple of newer patches 10:11:03 <anarcat> i see 10:11:19 <anarcat> well, other projects may also profit from your wisdom, so maybe this should be officially published as a fork? 10:11:22 <hanatos> every so often we try to backport new camera support.. 10:11:43 <hanatos> but i don't remember when that last happened 10:11:50 <hanatos> really we're quite happy with rawspeed 10:11:58 <hanatos> and libraw also uses rawspeed sometimes.. 10:12:06 <hanatos> so it's a wild cyclic dependency mess 10:12:13 <anarcat> hehe fun 10:12:44 <hanatos> https://github.com/lifthoofd/ofxExiv2/blob/master/exiv2/include/easyaccess.hpp 10:12:53 <hanatos> if this whiteBalance call 10:12:58 <hanatos> would also have a daylightWhiteBalance() 10:13:02 <hanatos> we would be all good 10:13:17 <anarcat> https://github.com/lifthoofd/ofxExiv2/issues/new ;) 10:13:19 <hanatos> not sure how many more cameras libraw supports than rawspeed 10:13:51 <anarcat> i need to run, thanks for the feedback, i'll integrate this in the debian BTS 10:13:52 <hanatos> that's some fork, is it? i'd open it with exiv2 directly 10:13:56 <hanatos> cool, cya So there are some bits missing from those upstream libraries and someone needs to go around opening issues with *those* upstreams to have those libraries patched. A. -- That's one of the remarkable things about life: it's never so bad that it can't get worse. - Calvin
pgpVSMAFazz69.pgp
Description: PGP signature
