On 26/06/13 15:57, Petter Reinholdtsen wrote: > [Tomasz Buchert] > > Hi, > > I'm afraid the fix does not make stellarium work over rdesktop, but > > rather lets it quit gracefully instead of segfaulting. I doubt you > > can use OpenGL applications over rdesktop efficiently if at all. But > > I'm not expert nor a developer of Stellarium. :) > > Right. That will at least provide the Debian Edu users with some > explanation why it do not work. > > The patch for solving the issue was a bit strange, though. One of the > 'if' blocks had no return statement, causing no return value from the > function... > > -- > Happy hacking > Petter Reinholdtsen
I'm pretty sure the Stellarium guys know what they are doing: https://qt-project.org/doc/qt-4.8/qcoreapplication.html#quit so you don't actually return from quit(). If you are really pedantic and think that it may result in "undefined behavior", then see what C++ author has to say about it: http://www.stroustrup.com/bs_faq2.html#void-main So, in the end, I think it's fine. :D Also, I don't think it is justified to backport this fix to wheezy as it's not security related nor it breaks the user experience very much. Thanks for the bug report, Tomasz -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
